configuration_script_sources subcollection #15070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtayadeway
reviewed
May 11, 2017
| module Subcollections | ||
| module ConfigurationScriptPayloads | ||
| def configuration_script_payloads_query_resource(object) | ||
| object.respond_to?(:configuration_script_payloads) ? object.configuration_script_payloads : [] |
There was a problem hiding this comment.
Do not all ConfigurationScripts respond to configuration_script_payloads? If they don't, can you add a test showing that this check is necessary?
imtayadeway
approved these changes
May 11, 2017
…_script_sources add filter spec
|
Checked commit jntullo@111b23e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_label fine/yes |
|
This LGTM!! Thanks @jntullo for the enhancement. 👍 |
simaishi
pushed a commit
that referenced
this pull request
Jun 8, 2017
configuration_script_sources subcollection (cherry picked from commit 632c2d0) https://bugzilla.redhat.com/show_bug.cgi?id=1459986
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this BZ, it is necessary to filter on
region_numberof playbooks that belong to a repository.While this can be achieved via
adding it as a subcollection makes it possible to filter on the
configuration_script_sourcescollection directly:@miq-bot add_label enhancement, api
@miq-bot assign @abellotti
cc: @h-kataria @gmcculloug