Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary filtercount functions from explorer views #1117

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Removed unnecessary filtercount functions from explorer views #1117

merged 2 commits into from
Oct 20, 2017

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Oct 19, 2017 •
edited
Loading

field subquery_count is used as this does not change with the max_results_per_page flag

closes #1114

@AllenBW AllenBW added the wip label Oct 19, 2017
@AllenBW AllenBW force-pushed the bug/#1114-update-explorer-pagination branch from 1c5b8d3 to 13a3614 Compare October 19, 2017 20:15
@AllenBW AllenBW added the bug label Oct 19, 2017
@AllenBW
Copy link
Member Author

AllenBW commented Oct 19, 2017

So we have a question @chriskacerguis SO this works, fixes the issue butttttt lets say you have a super fun admin that sets the limit to 1, but pagination in the sui gives the illusion that you could set the limit to 20, 100, 1000… would be great to say “oh, no, sorry user, not options, limit locked in at 1”

The max_results_per_page may one day be exposed to the api, which at that point we can use it to inform our pagination limit, but until that timeeeeeeeeeee I vote we merge this in, cuz broken things need to be fixed

cc: @imtayadeway 👋 ❤️ , @abellotti 🙇 🍕

@imtayadeway
Copy link
Contributor

@AllenBW did I help you delete code? ❤️ ❤️ ❤️

@miq-bot
Copy link
Member

miq-bot commented Oct 19, 2017

This pull request is not mergeable. Please rebase and repush.

@chriskacerguis chriskacerguis self-assigned this Oct 19, 2017
@AllenBW
Copy link
Member Author

AllenBW commented Oct 20, 2017

YOU DID!!!! <3 <3 <3 @imtayadeway

@AllenBW AllenBW force-pushed the bug/#1114-update-explorer-pagination branch from 13a3614 to 3be281d Compare October 20, 2017 11:44
@AllenBW
Removed unnecessary filtercount functions from explorer views
68cd905 
field subquery_count is used as this does not change with the max_results_per_page flag
@AllenBW
Update navigation badges to utilize subquery_count
778dd39
@AllenBW AllenBW force-pushed the bug/#1114-update-explorer-pagination branch from 3be281d to 778dd39 Compare October 20, 2017 11:49
@miq-bot
Copy link
Member

miq-bot commented Oct 20, 2017

Checked commits AllenBW/manageiq-ui-service@68cd905~...778dd39 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@AllenBW AllenBW removed the wip label Oct 20, 2017
@AllenBW AllenBW changed the title [WIP]Removed unnecessary filtercount functions from explorer views Removed unnecessary filtercount functions from explorer views Oct 20, 2017
@AllenBW
Copy link
Member Author

AllenBW commented Oct 20, 2017 •
edited
Loading

Created ManageIQ/manageiq-api#136 to track the follow on work for to this pr

@AllenBW AllenBW added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 20, 2017
@chriskacerguis chriskacerguis merged commit 2f18cfb into ManageIQ:master Oct 20, 2017
@AllenBW AllenBW deleted the bug/#1114-update-explorer-pagination branch October 20, 2017 13:55
@AllenBW AllenBW mentioned this pull request Nov 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskacerguis chriskacerguis chriskacerguis approved these changes

Assignees

@chriskacerguis chriskacerguis

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update explorer pagination to use subquery_count for pagination
4 participants
@AllenBW @imtayadeway @miq-bot @chriskacerguis