BZ#1507108-"filter", is correct option, subquery_count (to display filter results) #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollectionsApi service uses "filter" as the option from which to build the filter chain When filtering on a query, subquery_count will display the count of the query (where count will display the total results, sans influence of options)
|
Checked commit AllenBW@2c55bb9 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
chriskacerguis
approved these changes
Nov 6, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 7, 2017
…te-nav-counts BZ#1507108-"filter", is correct option, subquery_count (to display filter results) (cherry picked from commit bbc64e0) https://bugzilla.redhat.com/show_bug.cgi?id=1510250
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1507108
Looks like we had a regression from #1117
CollectionsApi service uses "filter" as the option from which to build the filter chain
When filtering on a query, subquery_count will display the count of the query (where count will display the total results, sans influence of options)
previously My Orders had a count of 7 😭, but checkit below, working!! 🙌