Update Cloud Image View to Differentiate Between Snapshots and Non-Snapshots #12970
Conversation
|
|
||
| def snapshot_or_image | ||
| genealogy_parent.nil? ? _("Image") : _("Snapshot") | ||
| end |
There was a problem hiding this comment.
This looks like UI decorator code. I think the model can add boolean predicates -- snapshot? and image? methods. These can then be consumed by UI code.
There was a problem hiding this comment.
UI code now handles what to display based on the predicate methods.
mansam
force-pushed
the
update-image-view-to-differentiate-between-snapshots-and-non-snapshots
branch
2 times, most recently
from
b88b446
to
5425e6d
Compare
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
mansam
force-pushed
the
update-image-view-to-differentiate-between-snapshots-and-non-snapshots
branch
from
5425e6d
to
fd0fcbc
Compare
|
This is now just the predicates and the changes to the yaml view. The controller changes are being moved to the new UI repo. |
| @@ -24,6 +24,7 @@ cols: | |||
| - allocated_disk_storage | |||
| - last_scan_on | |||
| - region_description | |||
| - image? | |||
There was a problem hiding this comment.
Can you do a white-space cleanup on this file to remove these ^M characters?
There was a problem hiding this comment.
I can. I'm not sure why this file (and several other of these yamls) seems to have windows style line endings.
|
This pull request is not mergeable. Please rebase and repush. |
|
@mansam my fault for not testing this in quite a while! I couldn't quite see the changes in the UI; I'm looking at the "Provision Instances - Select an Image" page, but let me know if I'm looking in the wrong place! |
mansam
force-pushed
the
update-image-view-to-differentiate-between-snapshots-and-non-snapshots
branch
from
06de802
to
ba7d4d1
Compare
|
Checked commits mansam/manageiq@9be6d7c~...ba7d4d1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 verified this updates the image view correctly |
|
@miq-bot assign @blomquisg |
|
@h-kataria I was asked by @chessbyte to change the pre-existing line endings in that file, which should explain why the diff includes the whole file. See the comments here: #12970 (comment) |
|
@mansam sorry i didn't notice that. |
|
@h-kataria no worries, github did a good job of hiding those comments :) |
This PR updates the Cloud Image view with a Type column that identifies Cloud Images as Snapshots if they descend from a parent VM.
@tzumainn