Added virtual_column 'image?' for ::CloudManager::Template #14613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
approved these changes
Apr 3, 2017
|
Checked commit jzigmund@0c5027b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
It seems it was working a few days ago (#12970), do we know what caused this bug? I am wondering because, there might be similar breakages with the common cause. |
|
@isimluk according to the changes in https://github.com/ManageIQ/manageiq/pull/12970/files the differentiating of the type (Image vs. snapshot) has been added. This is bugfix for sorting the column Type, I believe the author/reviewer just didn't test and notice that's the sorting is not working. |
|
Aah, now I get it. Thanks! |
isimluk
approved these changes
Apr 4, 2017
simaishi
pushed a commit
that referenced
this pull request
Apr 5, 2017
Added virtual_column 'image?' for ::CloudManager::Template (cherry picked from commit 4c38092) https://bugzilla.redhat.com/show_bug.cgi?id=1439397
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fixing the error
ActiveRecord::StatementInvalid] PG::UndefinedColumn: ERROR: column vms.image? does not existwhen user tries to sort Images by column 'Type'.@lpichler thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1437765