Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DARGA] bower.json - always use ~ to set dependency, update to current state #13143

Merged
merged 1 commit into from
Dec 13, 2016
Merged

[DARGA] bower.json - always use ~ to set dependency, update to current state #13143

merged 1 commit into from
Dec 13, 2016

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Dec 13, 2016

This is a darga version of #12078, to address the recent breakage with darga starting to depend on angular 1.6.

Cc: @mtho11 @hayesr

given the recent codemirror breakage (#12077), I'm updating our `bower.json` to always use `~` for dependencies (`~1.2.3` is `>= 1.2.3 && < 1.3.0`, whereas `^1.2.3` is `>= 1.2.3`).
@miq-bot
Copy link
Member

miq-bot commented Dec 13, 2016

Checked commit https://github.com/himdel/manageiq/commit/ca9b65fa6c9cbc57c34e978ebc0d962d42088c3f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🍪

@Fryguy
Copy link
Member

Fryguy commented Dec 13, 2016

@himdel This is failing with es6-shim

@himdel
Copy link
Contributor Author

himdel commented Dec 13, 2016

@Fryguy it's that usual (:point_down:) bower connectivity issue :( but since we do need the tests to pass to be sure.. restarting..

bower retry         Download of https://github.com/moment/moment-timezone/archive/0.4.1.tar.gz failed with EINCOMPLETE, trying with git..
events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: ENOENT, rename '/tmp/travis/bower/87f48d7c4646ec50a0339e33158bdd33-4134-D9G1zd/archive.tar.gz.2082589147'

@himdel
Copy link
Contributor Author

himdel commented Dec 13, 2016

And green :)

@chessbyte chessbyte merged commit a3199cf into ManageIQ:darga Dec 13, 2016
@chessbyte chessbyte added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 13, 2016
@himdel himdel deleted the darga-bower-caret-tilde branch December 13, 2016 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants