Symbolize keys passed to provider methods #14685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jntullo that seems all we need. |
|
Checked commit jntullo@22e0867 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Hi @jntullo did this not work before ? If not, do we need tests ? |
|
@abellotti was working, but causing the provider methods to check for both strings and key |
|
Thanks @jntullo 👍 |
simaishi
pushed a commit
that referenced
this pull request
Apr 7, 2017
Symbolize keys passed to provider methods (cherry picked from commit 5e5bb9d)
|
Fine backport details: |
jameswnl
added a commit
to jameswnl/manageiq
that referenced
this pull request
Apr 10, 2017
can because of ManageIQ#14685
abellotti
modified the milestones:
Sprint 59 Ending Apr 24, 2017,
Sprint 58 Ending Apr 10, 2017
juliancheal
pushed a commit
to ManageIQ/manageiq-providers-ansible_tower
that referenced
this pull request
May 11, 2017
can because of ManageIQ/manageiq#14685 (transferred from ManageIQ/manageiq@ced7fac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbolizing the keys as needed for the provider methods
cc: @blomquisg
@miq-bot assign @abellotti
@miq-bot add_label api
Did I miss any @jameswnl ?