[EUWE] Revert ruby 2.3.5 upgrade on travis #16087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-travis" This reverts commit 4b4ff11.
jrafanie
changed the title
|
cc @simaishi |
|
Checked commit jrafanie@b325783 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Mar 26, 2018
We previously tried to upgrade to 2.3.6 on euwe by backporting: ManageIQ#15993 This was causing a hang in the automation test suite on euwe and we reverted it in: ManageIQ#16087 We now need to figure out why it's hanging so we can upgrade to 2.3.6+ on euwe.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Mar 29, 2018
We previously tried to upgrade to 2.3.6 on euwe by backporting: ManageIQ#15993 This was causing a hang in the automation test suite on euwe and we reverted it in: ManageIQ#16087 We now need to figure out why it's hanging so we can upgrade to 2.3.6+ on euwe.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Mar 29, 2018
We previously tried to upgrade to 2.3.6 on euwe by backporting: ManageIQ#15993 This was causing a hang in the automation test suite on euwe and we reverted it in: ManageIQ#16087 https://bugzilla.redhat.com/show_bug.cgi?id=1560578 The prior 2 commits contain a manual backport of ManageIQ#14239 which solves the 100% cpu hang of the automate ruby method with ruby 2.3.2+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4b4ff11.
Reverting #15993 for now, we keep having our travis builds on euwe hang on ruby versions > 2.3.1 (such as 2.3.5 or even 2.4.2). Perhaps it's due to
the fix in 2.3.2 for the timer threads with drb:
First fixed in:
ruby/ruby@e143a74#diff-4b0b8a13c2d5172da441205f2e57f610
Then, it was changed to use a finalizer in:
ruby/ruby@021e8ea#diff-4b0b8a13c2d5172da441205f2e57f610