[EUWE] Update to 2.3.6 #17203
Merged
[EUWE] Update to 2.3.6 #17203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves dynamic method building into DrbRemoteInvoker since it isn't needed at all in MiqAeService. Once in DrbRemoteInvoker, we can use the dynamic preamble to inform the generated ruby method body of things like the number of preamble lines and the name of the method for backtrace filtering purposes.
We previously tried to upgrade to 2.3.6 on euwe by backporting: ManageIQ#15993 This was causing a hang in the automation test suite on euwe and we reverted it in: ManageIQ#16087 https://bugzilla.redhat.com/show_bug.cgi?id=1560578 The prior 2 commits contain a manual backport of ManageIQ#14239 which solves the 100% cpu hang of the automate ruby method with ruby 2.3.2+.
|
Some comments on commits jrafanie/manageiq@3da93b0~...3c74c05 spec/lib/miq_automation_engine/engine/miq_ae_method_spec.rb
|
|
Checked commits jrafanie/manageiq@3da93b0~...3c74c05 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously tried to upgrade to 2.3.6 on euwe by backporting:
#15993
This was causing a hang in the automation test suite on euwe and we
reverted it in:
#16087
https://bugzilla.redhat.com/show_bug.cgi?id=1560578
This PR contains a manual backport of #14239 which solves the 100%
cpu hang of the automate ruby method with ruby 2.3.2+.