simplify fix_auth tests #23212
Open
simplify fix_auth tests #23212
+0
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not saying we shouldn't merge but would it be better to keep the tests and just mark them as pending or |
|
also I'm surprised at the removal of some of these - I wouldn't have expected blank column to need to be removed, for example |
Fryguy
reviewed
Sep 27, 2024
Comment on lines
-81
to
-84
| it "should replace for bad encryption" do | ||
| subject.fix_passwords(bad, options.merge(:invalid => "other")) | ||
| expect(bad.password).to be_encrypted("other") | ||
| end |
There was a problem hiding this comment.
This was the only one I expected to go away, cause I've seen this one fail - can't say the same for the others.
There is an issue in the way that encryption keys work. You can sometimes decrypt a string that has been encoded with a different passkey. You will get the wrong value out, but the system thinks that it succeeded. Even though the odds of this are very low, since we run managiq so many times, we run across it as a sporadic test failure. This is an issue and we're removing the offending tests. This functionality is tested in the `manageiq-password` gem.
|
update:
|
|
Checked commit kbrock@a5440c5 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
approved these changes
Sep 27, 2024
|
kicking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in the way that encryption keys work. You can sometimes decrypt a string that has been encoded with a different passkey. You will get the wrong value out, but the system thinks that it succeeded.
Even though the odds of this are very low, since we run managiq so many times, we run across it as a sporadic test failure.
This is an issue and we're removing the offending tests. This functionality is tested in the
manageiq-passwordgem.