Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify fix_auth tests #23212

Merged
merged 1 commit into from
Sep 30, 2024
Merged

simplify fix_auth tests #23212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions spec/tools/fix_auth/auth_model_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,6 @@
expect { subject.fix_passwords(bad, options) }.to raise_error(ManageIQ::Password::PasswordError)
end

it "should replace for bad encryption" do
subject.fix_passwords(bad, options.merge(:invalid => "other"))
expect(bad.password).to be_encrypted("other")
end
Comment on lines -81 to -84
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the only one I expected to go away, cause I've seen this one fail - can't say the same for the others.


context "with the rare case where recryption succeeds but returns garbage" do
# NOTE: This legacy key only returns garbage specifically with the
# built-in v2_key.dev and the plaintext string "password", which is
Expand Down