Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompiled lib, use webpack and update dependency versions #31

Closed
wants to merge 7 commits into from

Conversation

scags9876
Copy link

Some useful stuff in here, thought others might benefit from these changes.

  • using webpack instead of grunt and browserify
  • including babelfied lib
  • upgrading dependencies to work with react 15
  • upgrade to lodash 4.x

he8us and others added 5 commits July 1, 2016 10:49
Moved from browserify and grunt to webpack
Use babel with react preset
Npm based build
- Set react dependencies to >=0.14.x so that it will accept react 15
@MandarinConLaBarba
Copy link
Owner

Thanks very much for this! I am out of town for a week but will review this when I get back..

@MandarinConLaBarba
Copy link
Owner

@scags9876 running webpack doesn't appear to create transpiled .js for distribution, which seems to be what #23 and #19 call for. Running webpack creates a bundle that includes the example application, but that isn't what we'd want to ship with npm publish.

@scags9876
Copy link
Author

@MandarinConLaBarba sorry for the late response, been a busy week. I believe the command to use is npm run prepublish I add a small section to the readme to explain the various npm commands. 😸

@MandarinConLaBarba
Copy link
Owner

Great, thanks. I would think that the transpiled code would be included in the npm package, but not in source. Meaning, lib/*.js would be in .gitignore so that it would be kept out of the repository. Thoughts?

@scags9876
Copy link
Author

Ah yes, you are correct @MandarinConLaBarba . I'm using it checked in so that I can import directly from github:

"react-tree-menu": "git://github.com/scags9876/react-tree-menu.git",

I can make this change... I might need to submit a new PR for it though since I'd like to do it in a branch of my fork so that I can continue to import my master until you merge this.

@scags9876
Copy link
Author

Ok, #32 has been opened and replaces this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants