Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precompiled lib, use webpack and update dependency versions #32

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Precompiled lib, use webpack and update dependency versions #32

wants to merge 9 commits into from

Conversation

scags9876
Copy link

Some useful stuff in here, thought others might benefit from these changes.

  • using webpack instead of grunt and browserify
  • including a prepublish script to precompile transpiled code and include it in a lib directory in the package published on npm
  • upgrading dependencies to work with react 15
  • upgrade to lodash 4.x

he8us and others added 7 commits July 1, 2016 10:49
@he8us
Added Prepublish hook
0f592ad 
Moved from browserify and grunt to webpack
Use babel with react preset
Npm based build
@jbrodriguez
Publish precompiled lib
683858e
@scags9876
Upgrade to work with react 15
7c773d8 
- Set react dependencies to >=0.14.x so that it will accept react 15
@scags9876
Upgrade lodash to 4.x
672c667
@scags9876
Bump version to 1.5.2
167d9de
@scags9876
Add some docs for the development scripts
6f53dc9
@scags9876
update bundle
688eb9e
@scags9876
Copy link
Author

Addresses:

#23
#19
#21

@scags9876 scags9876 mentioned this pull request Feb 15, 2017
Closed
@jbrodriguez
Copy link

@scags9876 have you published your 'fork' to npm ?

If that's not the case, how can one use your code directly from github (since the compiled lib doesn't exist in github)

@scags9876
Copy link
Author

@jbrodriguez I have not published to npm... I'm waiting for @MandarinConLaBarba to merge this PR so he can publish.

In the meantime, i've got the following in my package.json:

"react-tree-menu": "git://github.com/scags9876/react-tree-menu.git",

It points to my master branch on my fork, which has the precompiled lib... see #31 (comment)

@scags9876
Copy link
Author

this PR now includes the fix for the undefined PropType from #33

@scags9876
Update to support react v15
4e2ead1 
These mainly address deprecation warnings given with react 15.

 - Remove soon to be deprecated React.propTypes in favor of the PropTypes package.  See https://fb.me/prop-types-docs
 - Remove soon to be deprecated React.createClass in favor of the creatReactClass package. See https://fb.me/react-create-class
 - Fix bug with undefined propType warning
@scags9876
Remove compiled lib from git
a1e3b3d
@xitarps
Copy link

xitarps commented Nov 26, 2021

@jbrodriguez I have not published to npm... I'm waiting for @MandarinConLaBarba to merge this PR so he can publish.

In the meantime, i've got the following in my package.json:

"react-tree-menu": "git://github.com/scags9876/react-tree-menu.git",

It points to my master branch on my fork, which has the precompiled lib... see #31 (comment)

Thanks!! helped me a lot!! /o/
Mandou muito! (BR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scags9876 @jbrodriguez @xitarps @he8us