Clean up spelling, wording and punctuation #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install.sh
Outdated
| @@ -103,7 +103,7 @@ show_menu () { | |||
| ;; | |||
| 6) | |||
| sudo /etc/init.d/craftbeerpiboot stop | |||
| whiptail --title "CraftBeerPi stoped" --msgbox "The software is stoped" 8 78 | |||
| whiptail --title "CraftBeerPi stoped" --msgbox "The software is stopped." 8 78 | |||
|
Looks all good to me! |
|
;-) thanks for opening my eyes! |
| hop_2_added = Property.Number("", default_value=None) | ||
| hop_3 = Property.Number("Hop 3 Addition", configurable=True) | ||
| hop_3_added = Property.Number("", default_value=None, description="Second Hop alert") | ||
| hop_3_added = Property.Number("", default_value=None, description="Second hop alert.") |
modules/recipe_import/kbh.py
Outdated
| @@ -30,7 +30,7 @@ def get(self): | |||
| return json.dumps(result) | |||
| except Exception as e: | |||
| print e | |||
| self.api.notify(headline="Failed to load KHB database", message="ERROR", type="danger") | |||
| self.api.notify(headline="Failed to load KHB database.", message="ERROR", type="danger") | |||
There was a problem hiding this comment.
KHB is a new acronym not explained before.
| temp = Property.Number("Temperature", configurable=True, default_value=100, description="Target temperature for boiling.") | ||
| kettle = StepProperty.Kettle("Kettle", description="Kettle in which the boiling step takes place.") | ||
| timer = Property.Number("Timer in Minutes", configurable=True, default_value=90, description="Timer is started when target temperature is reached.") | ||
| hop_1 = Property.Number("Hop 1 Addition", configurable=True, description="Fist hop alert.") |
|
Could this PR be integrated? It seems like a lot of work went into this, it would be a shame if it rots away. |
|
Please consider this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.