-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up spelling, wording and punctuation #93
Open
flo269
wants to merge
15
commits into
Manuel83:master
Choose a base branch
from
flo269:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f86c376
Clean up spelling and wording
flo269 716ab49
One more typo cleaned up
flo269 e2dc261
Update __init__.py
flo269 3e1be62
Update README.md
flo269 c20536e
Typos and punctuation fixed
flo269 532431a
Update restapi.py
flo269 59b15ed
Wording and punctuation
flo269 5b293e8
punctuation and wording
flo269 953199f
wording
flo269 296ec09
punctuation
flo269 d388933
capitalization and punctuation
flo269 a7d6b1b
Update __init__.py
flo269 11cee90
Update kbh.py
flo269 b1eb082
Update __init__.py
flo269 59b5954
Merge remote-tracking branch 'Manuel83/master'
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,9 +14,9 @@ class MashStep(StepBase): | |
Just put the decorator @cbpi.step on top of a method | ||
''' | ||
# Properties | ||
temp = Property.Number("Temperature", configurable=True, description="Target Temperature of Mash Step") | ||
kettle = StepProperty.Kettle("Kettle", description="Kettle in which the mashing takes place") | ||
timer = Property.Number("Timer in Minutes", configurable=True, description="Timer is started when the target temperature is reached") | ||
temp = Property.Number("Temperature", configurable=True, description="Target temperature of mash step.") | ||
kettle = StepProperty.Kettle("Kettle", description="Kettle in which the mashing takes place.") | ||
timer = Property.Number("Timer in Minutes", configurable=True, description="Timer is started when the target temperature is reached.") | ||
|
||
def init(self): | ||
''' | ||
|
@@ -66,8 +66,8 @@ class MashInStep(StepBase): | |
Just put the decorator @cbpi.step on top of a method | ||
''' | ||
# Properties | ||
temp = Property.Number("Temperature", configurable=True, description="Target Temperature of Mash Step") | ||
kettle = StepProperty.Kettle("Kettle", description="Kettle in which the mashing takes place") | ||
temp = Property.Number("Temperature", configurable=True, description="Target temperature of mash step.") | ||
kettle = StepProperty.Kettle("Kettle", description="Kettle in which the mashing takes place.") | ||
s = False | ||
|
||
@cbpi.action("Change Power") | ||
|
@@ -94,14 +94,14 @@ def execute(self): | |
# Check if Target Temp is reached | ||
if self.get_kettle_temp(self.kettle) >= float(self.temp) and self.s is False: | ||
self.s = True | ||
self.notify("Step Temp Reached!", "Please press the next button to continue", timeout=None) | ||
self.notify("Step temperature reached!", "Please press the next button to continue.", timeout=None) | ||
|
||
|
||
|
||
@cbpi.step | ||
class ChilStep(StepBase): | ||
|
||
timer = Property.Number("Timer in Minutes", configurable=True, default_value=0, description="Timer is started immediately") | ||
timer = Property.Number("Timer in Minutes", configurable=True, default_value=0, description="Timer is started immediately.") | ||
|
||
@cbpi.action("Stat Timer") | ||
def start(self): | ||
|
@@ -125,8 +125,8 @@ def execute(self): | |
@cbpi.step | ||
class PumpStep(StepBase): | ||
|
||
pump = StepProperty.Actor("Pump", description="Pump actor gets toogled") | ||
timer = Property.Number("Timer in Minutes", configurable=True, default_value=0, description="Timer is started immediately") | ||
pump = StepProperty.Actor("Pump", description="Pump actor gets toggled.") | ||
timer = Property.Number("Timer in Minutes", configurable=True, default_value=0, description="Timer is started immediately.") | ||
|
||
@cbpi.action("Stat Timer") | ||
def start(self): | ||
|
@@ -156,15 +156,15 @@ class BoilStep(StepBase): | |
Just put the decorator @cbpi.step on top of a method | ||
''' | ||
# Properties | ||
temp = Property.Number("Temperature", configurable=True, default_value=100, description="Target temperature for boiling") | ||
kettle = StepProperty.Kettle("Kettle", description="Kettle in which the boiling step takes place") | ||
timer = Property.Number("Timer in Minutes", configurable=True, default_value=90, description="Timer is started when target temperature is reached") | ||
hop_1 = Property.Number("Hop 1 Addition", configurable=True, description="Fist Hop alert") | ||
temp = Property.Number("Temperature", configurable=True, default_value=100, description="Target temperature for boiling.") | ||
kettle = StepProperty.Kettle("Kettle", description="Kettle in which the boiling step takes place.") | ||
timer = Property.Number("Timer in Minutes", configurable=True, default_value=90, description="Timer is started when target temperature is reached.") | ||
hop_1 = Property.Number("Hop 1 Addition", configurable=True, description="Fist hop alert.") | ||
hop_1_added = Property.Number("",default_value=None) | ||
hop_2 = Property.Number("Hop 2 Addition", configurable=True, description="Second Hop alert") | ||
hop_2 = Property.Number("Hop 2 Addition", configurable=True, description="Second hop alert.") | ||
hop_2_added = Property.Number("", default_value=None) | ||
hop_3 = Property.Number("Hop 3 Addition", configurable=True) | ||
hop_3_added = Property.Number("", default_value=None, description="Second Hop alert") | ||
hop_3_added = Property.Number("", default_value=None, description="Second hop alert.") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be third |
||
|
||
def init(self): | ||
''' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ def get(self): | |
conn = None | ||
try: | ||
if not os.path.exists(self.api.app.config['UPLOAD_FOLDER'] + '/kbh.db'): | ||
self.api.notify(headline="File Not Found", message="Please upload a Kleiner Brauhelfer Database", type="danger") | ||
self.api.notify(headline="File Not Found", message="Please upload a Kleiner Brauhelfer database.", type="danger") | ||
return ('', 404) | ||
|
||
conn = sqlite3.connect(self.api.app.config['UPLOAD_FOLDER'] + '/kbh.db') | ||
|
@@ -30,7 +30,7 @@ def get(self): | |
return json.dumps(result) | ||
except Exception as e: | ||
print e | ||
self.api.notify(headline="Failed to load KHB database", message="ERROR", type="danger") | ||
self.api.notify(headline="Failed to load KHB database.", message="ERROR", type="danger") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. KHB is a new acronym not explained before. |
||
return ('', 500) | ||
finally: | ||
if conn: | ||
|
@@ -47,11 +47,11 @@ def upload_file(self): | |
if file and self.allowed_file(file.filename): | ||
filename = secure_filename(file.filename) | ||
file.save(os.path.join(self.api.app.config['UPLOAD_FOLDER'], "kbh.db")) | ||
self.api.notify(headline="Upload Successful", message="The Kleiner Brauhelfer Database was uploaded succesfully") | ||
self.api.notify(headline="Upload Successful", message="The Kleiner Brauhelfer database was succesfully uploaded.") | ||
return ('', 204) | ||
return ('', 404) | ||
except Exception as e: | ||
self.api.notify(headline="Upload Failed", message="Failed to upload Kleiner Brauhelfer", type="danger") | ||
self.api.notify(headline="Upload Failed", message="Failed to upload Kleiner Brauhelfer database.", type="danger") | ||
|
||
return ('', 500) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should say First not fist