Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditional do_probe_raise() in probe_pt() #4183

Merged

Conversation

AnHardt
Copy link
Member

@AnHardt AnHardt commented Jul 1, 2016

If Z_RAISE_BETWEEN_PROBINGS is null or undefined the probe is currently not raised by home_offset[Z_AXIS] and zprobe_zoffset. But when the smallest bit different from 0 it is.

If an undefined Z_RAISE_BETWEEN_PROBINGS expands to 0 (and it does) this is the solution.

A similar asymmetry exists with the newly introduced 'short-cut' in G28 - but it's the rise before anything is probed - so should not make a difference.

This asymmetry likely causes the effects in #4177

If Z_RAISE_BETWEEN_PROBINGS is null or undefined the probe is currently not raised by home_offset[Z_AXIS] and zprobe_zoffset.
But when different from 0 is.

If an undefined Z_RAISE_BETWEEN_PROBINGS expands to 0 (and it does) this is the solution.


A similar asymmetry exists with the newly introduced 'short-cut' in G28 - but its the rise before anything is probed - so should not make a difference.
@thinkyhead
Copy link
Member

thinkyhead commented Jul 1, 2016

@AnHardt This may only be covering up a bug, I think. For one thing we do not want anything "raised by home_offset[Z_AXIS] and zprobe_zoffset." The zero point for Z is not 0.0, but home_offset[Z_AXIS]. So whenever the probe hits the bed, the current_position[Z_AXIS] (for the nozzle) is supposed to be set to home_offset[Z_AXIS] - zprobe_zoffset. Then if we raise the nozzle by Z_RAISE_BETWEEN_PROBINGS it only moves up by that amount, to home_offset[Z_AXIS] - negative_zprobe_zoffset + Z_RAISE_BETWEEN_PROBINGS.

Is this already considered here?

I can see that skipping the raise would be a problem for a positive zprobe_zoffset (where the nozzle is the probe) because we need to raise to at least 0.0 just to get the nozzle off the bed.

@thinkyhead thinkyhead merged commit b4fee31 into MarlinFirmware:RCBugFix Jul 1, 2016
@AnHardt AnHardt deleted the do_probe_raise-asymetry branch July 2, 2016 11:53
@thinkyhead thinkyhead mentioned this pull request Jul 8, 2016
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request May 31, 2024
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request May 31, 2024
Clean up mesh definitions that where made obsolete by MarlinFirmware#4183
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request May 31, 2024
drewmoseley pushed a commit to drewmoseley/Marlin that referenced this pull request May 31, 2024
…area_translations

🚧  Add new MBL message for MarlinFirmware#4183 and translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants