Extend Printcounter on LCD over 22 days #4312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
| int hrs = long(stats.printTime / 60 / 60) % 24; | ||
| int day = int(stats.printTime / 60 / 60 / 24); | ||
| char timeString[14]; | ||
| sprintf_P(timeString, PSTR("%i%s %i%s %02i%s"), day, MSG_SHORT_DAY, hrs, MSG_SHORT_HOUR, min, MSG_SHORT_MINUTE); |
There was a problem hiding this comment.
This will produce smaller code as it uses less string storage and encourages the compiler to skip creating temporary variables:
sprintf_P(timeString,
PSTR("%i" MSG_SHORT_DAY " %i" MSG_SHORT_HOUR " %i" MSG_SHORT_MINUTE),
int(stats.printTime / 60 / 60 / 24),
int((stats.printTime / 60 / 60) % 24),
int((stats.printTime / 60) % 60)
);There was a problem hiding this comment.
@thinkyhead OK, you got me. Tried that previously, but I thought, I can't do modulus (%) with decimals or whatewer it is. And converting to long caused weird bugs inside Arduino, so I used temporary vars. Now OK?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #4287 allowed longer counting in Printcounter, we should implement it in LCD Info menu. This PR handles with second as long (int32) and adds days counter. That extends LCD to display up to 4 billion seconds or 25 000 days. That lot more than current 32 thousand minutes or 22 days. Timer is moved to next line to fit into 16-char display.
If merged, will need some help from @MarlinFirmware/language-team