-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle null job.latestRun
before runStateColor
#2467
Handle null job.latestRun
before runStateColor
#2467
Conversation
Signed-off-by: Perttu Salonen <[email protected]>
Signed-off-by: Perttu Salonen <[email protected]>
Signed-off-by: Perttu Salonen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2467 +/- ##
============================================
- Coverage 83.60% 83.53% -0.07%
+ Complexity 1213 1207 -6
============================================
Files 231 231
Lines 5520 5503 -17
Branches 266 267 +1
============================================
- Hits 4615 4597 -18
Misses 762 762
- Partials 143 144 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, looks good.
* Handle null `job.latestRun` before `runStateColor` Signed-off-by: Perttu Salonen <[email protected]> * generate default color with `NEW` `runState` Signed-off-by: Perttu Salonen <[email protected]> * added changelog description Signed-off-by: Perttu Salonen <[email protected]> --------- Signed-off-by: Perttu Salonen <[email protected]> Signed-off-by: Xavier-Cliquennois <[email protected]>
Problem
Fixes a bug where Jobs view fails to load where some jobs don't have
latestRun
Closes: #2462
Solution
Handle null
job.latestRun
before callingrunStateColor
and conditionally format the label.One-line summary:
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)