Skip to content

Commit

Permalink
Handle null job.latestRun before runStateColor (MarquezProject#2467)
Browse files Browse the repository at this point in the history
* Handle null `job.latestRun` before `runStateColor`

Signed-off-by: Perttu Salonen <[email protected]>

* generate default color with `NEW` `runState`

Signed-off-by: Perttu Salonen <[email protected]>

* added changelog description

Signed-off-by: Perttu Salonen <[email protected]>

---------

Signed-off-by: Perttu Salonen <[email protected]>
Signed-off-by: Xavier-Cliquennois <[email protected]>
  • Loading branch information
perttus authored and Xavier-Cliquennois committed Jul 26, 2023
1 parent 2748c6d commit 947c203
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [Unreleased](https://github.com/MarquezProject/marquez/compare/0.32.0...HEAD)

### Fixed

* UI: better handling of null job latestRun for Jobs page [#2467](https://github.com/MarquezProject/marquez/pull/2467) [@perttus](https://github.com/perttus)

### Added

* Support `inputFacets` and `outputFacets` from Openlineage specificatio [`#2417`](https://github.com/MarquezProject/marquez/pull/2417) [@pawel-big-lebowski]( https://github.com/pawel-big-lebowski)
Expand Down
4 changes: 2 additions & 2 deletions web/src/routes/jobs/Jobs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ class Jobs extends React.Component<JobsProps> {
</TableCell>
<TableCell key={i18next.t('jobs_route.latest_run_col')} align='left'>
<MqStatus
color={runStateColor(job.latestRun.state)}
label={job.latestRun.state}
color={job.latestRun && runStateColor(job.latestRun.state || 'NEW')}
label={job.latestRun && job.latestRun.state ? job.latestRun.state : 'N/A'}
/>
</TableCell>
</TableRow>
Expand Down

0 comments on commit 947c203

Please sign in to comment.