Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert URL encoding when fetching lineage #2529

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

jlukenoff
Copy link
Contributor

@jlukenoff jlukenoff commented Jun 28, 2023

Problem

When I converted this to use the URLSearchParams in #2525, we started inadvertently url-encoding the node id, which causes problems if the node id contains special characters.

Solution

This reverts node ID from being URL encoded and allows the backend to successfully return the lineage details even when the node ID contains special characters.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #2529 (6604314) into main (6814e18) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2529   +/-   ##
=========================================
  Coverage     83.80%   83.80%           
  Complexity     1233     1233           
=========================================
  Files           235      235           
  Lines          5625     5625           
  Branches        270      270           
=========================================
  Hits           4714     4714           
  Misses          767      767           
  Partials        144      144           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

jlukenoff and others added 2 commits June 28, 2023 08:41
Signed-off-by: John Lukenoff <[email protected]>
Signed-off-by: John Lukenoff <[email protected]>
Signed-off-by: John Lukenoff <[email protected]>
@jlukenoff jlukenoff changed the title Revert URL encoding Revert URL encoding when fetching lineage Jun 28, 2023
Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jlukenoff for this and the test!

@phixMe phixMe merged commit 1ce9aca into MarquezProject:main Jun 28, 2023
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 5, 2023
* Revert URL encoding

Signed-off-by: John Lukenoff <[email protected]>

* comment

Signed-off-by: John Lukenoff <[email protected]>

* Add a test

Signed-off-by: John Lukenoff <[email protected]>

---------

Signed-off-by: John Lukenoff <[email protected]>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
* Revert URL encoding

Signed-off-by: John Lukenoff <[email protected]>

* comment

Signed-off-by: John Lukenoff <[email protected]>

* Add a test

Signed-off-by: John Lukenoff <[email protected]>

---------

Signed-off-by: John Lukenoff <[email protected]>
Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
* Revert URL encoding

Signed-off-by: John Lukenoff <[email protected]>

* comment

Signed-off-by: John Lukenoff <[email protected]>

* Add a test

Signed-off-by: John Lukenoff <[email protected]>

---------

Signed-off-by: John Lukenoff <[email protected]>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
* Revert URL encoding

Signed-off-by: John Lukenoff <[email protected]>

* comment

Signed-off-by: John Lukenoff <[email protected]>

* Add a test

Signed-off-by: John Lukenoff <[email protected]>

---------

Signed-off-by: John Lukenoff <[email protected]>
Signed-off-by: Xavier-Cliquennois <[email protected]>
Signed-off-by: Xavier-Cliquennois <[email protected]>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
* Revert URL encoding

Signed-off-by: John Lukenoff <[email protected]>

* comment

Signed-off-by: John Lukenoff <[email protected]>

* Add a test

Signed-off-by: John Lukenoff <[email protected]>

---------

Signed-off-by: John Lukenoff <[email protected]>
Signed-off-by: Xavier-Cliquennois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants