Skip to content

Commit

Permalink
Revert URL encoding when fetching lineage (MarquezProject#2529)
Browse files Browse the repository at this point in the history
* Revert URL encoding

Signed-off-by: John Lukenoff <[email protected]>

* comment

Signed-off-by: John Lukenoff <[email protected]>

* Add a test

Signed-off-by: John Lukenoff <[email protected]>

---------

Signed-off-by: John Lukenoff <[email protected]>
Signed-off-by: Xavier-Cliquennois <[email protected]>
  • Loading branch information
jlukenoff authored and Xavier-Cliquennois committed Jul 26, 2023
1 parent 3ddb56f commit f802443
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions web/src/store/requests/lineage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@ export const getLineage = async (
name: string,
depth: number
) => {
const params = new URLSearchParams({
nodeId: generateNodeId(nodeType, namespace, name),
depth: depth.toString()
})
const url = `${API_URL}/lineage?${params.toString()}`
const nodeId = generateNodeId(nodeType, namespace, name)
// Node ID cannot be URL encoded
const url = `${API_URL}/lineage?nodeId=${nodeId}&depth=${depth}`
return genericFetchWrapper(url, { method: 'GET' }, 'fetchLineage')
}

0 comments on commit f802443

Please sign in to comment.