Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show tags refresh #2799

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

davidsharp7
Copy link
Member

@davidsharp7 davidsharp7 commented Apr 17, 2024

Problem

Currently with the changes from #2798 it's possibly introduced a slight bug in that it takes 2 toggles of the "Show Field Tags" to register the changes in the UI. Believe this is due to the lag between showTags dependencies and the new version being retrieved.

I've tried to limit the number of calls to the back end so rather then update on every tag addition/deletion it only updates when the "Show Field Tags" is toggled.

Solution

add showTags to the dependencies fetchDatasetVersions and disable the show tags toggle until the latest version has been pulled.

bug_refresh_tags.mov

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary:

Fix showTags bugs

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: sharpd <[email protected]>
@boring-cyborg boring-cyborg bot added the web label Apr 17, 2024
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 78e23d3
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66206a958a5d460008afd18c

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (d0a4207) to head (78e23d3).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2799   +/-   ##
=========================================
  Coverage     84.47%   84.47%           
  Complexity     1429     1429           
=========================================
  Files           251      251           
  Lines          6460     6460           
  Branches        299      299           
=========================================
  Hits           5457     5457           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidsharp7 davidsharp7 marked this pull request as ready for review April 18, 2024 00:51
@davidsharp7 davidsharp7 changed the title fix show tags fresh Fix show tags refresh Apr 18, 2024
Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! 🥳

@phixMe phixMe merged commit d6ac3e6 into MarquezProject:main Apr 18, 2024
16 checks passed
@wslulciuc wslulciuc added this to the 0.47.0 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants