Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix show tags refresh #2799

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Fix show tags refresh #2799

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf48e10
fix show tags fresh
davidsharp7 Apr 17, 2024
78e23d3
disable show tags on version load
davidsharp7 Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions web/src/components/datasets/DatasetDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,7 @@ const DatasetDetailPage: FunctionComponent<IProps> = (props) => {

useEffect(() => {
fetchDatasetVersions(lineageDataset.namespace, lineageDataset.name)
}, [lineageDataset.name])

useEffect(() => {
if (showTags) {
fetchDatasetVersions(lineageDataset.namespace, lineageDataset.name)
}
}, [showTags])
}, [lineageDataset.name, showTags])

// if the dataset is deleted then redirect to datasets end point
useEffect(() => {
Expand Down Expand Up @@ -219,6 +213,7 @@ const DatasetDetailPage: FunctionComponent<IProps> = (props) => {
checked={showTags}
onChange={() => setShowTags(!showTags)}
inputProps={{ 'aria-label': 'toggle show tags' }}
disabled={versionsLoading}
/>
}
label={i18next.t('datasets.show_field_tags')}
Expand Down
Loading