Skip to content

Commit

Permalink
(cake-buildGH-2658) Update unit tests
Browse files Browse the repository at this point in the history
Some tests were failing as a result of the changes.  Updated to
Substitute additional required items.
  • Loading branch information
gep13 authored and devlead committed May 19, 2020
1 parent 719e2df commit 1e3c6de
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public sealed class TheTFBuildMethod
public void Should_Throw_If_Context_Is_Null()
{
// Given, When
var result = Record.Exception(() => BuildSystemAliases.TFBuild(null));
var result = Record.Exception(() => BuildSystemAliases.AzurePipelines(null));

// Then
AssertEx.IsArgumentNullException(result, "context");
Expand Down
6 changes: 6 additions & 0 deletions src/Cake.Common.Tests/Unit/Build/BuildSystemTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -821,12 +821,15 @@ public void Should_Return_True_If_Running_On_AzurePipelines()
var goCDProvider = Substitute.For<IGoCDProvider>();
var gitLabCIProvider = Substitute.For<IGitLabCIProvider>();
var tfBuildProvider = Substitute.For<ITFBuildProvider>();
var tfBuildEnvironment = new TFBuildInfoFixture().CreateEnvironmentInfo();
var gitHubActionsProvider = Substitute.For<IGitHubActionsProvider>();
var azurePipelinesProvider = Substitute.For<IAzurePipelinesProvider>();
var azurePipelinesEnvironment = new AzurePipelinesInfoFixture().CreateEnvironmentInfo();

azurePipelinesProvider.IsRunningOnAzurePipelines.Returns(true);
azurePipelinesProvider.Environment.Returns(azurePipelinesEnvironment);
tfBuildProvider.IsRunningOnAzurePipelines.Returns(true);
tfBuildProvider.Environment.Returns(tfBuildEnvironment);

// When
var buildSystem = new BuildSystem(appVeyorProvider, teamCityProvider, myGetProvider, bambooProvider, continuaCIProvider, jenkinsProvider, bitriseProvider, travisCIProvider, bitbucketPipelinesProvider, goCDProvider, gitLabCIProvider, tfBuildProvider, gitHubActionsProvider, azurePipelinesProvider);
Expand Down Expand Up @@ -854,12 +857,15 @@ public void Should_Return_True_If_Running_On_AzurePipelinesHosted()
var goCDProvider = Substitute.For<IGoCDProvider>();
var gitLabCIProvider = Substitute.For<IGitLabCIProvider>();
var tfBuildProvider = Substitute.For<ITFBuildProvider>();
var tfBuildEnvironment = new TFBuildInfoFixture().CreateEnvironmentInfo();
var gitHubActionsProvider = Substitute.For<IGitHubActionsProvider>();
var azurePipelinesProvider = Substitute.For<IAzurePipelinesProvider>();
var azurePipelinesEnvironment = new AzurePipelinesInfoFixture().CreateEnvironmentInfo();

azurePipelinesProvider.IsRunningOnAzurePipelinesHosted.Returns(true);
azurePipelinesProvider.Environment.Returns(azurePipelinesEnvironment);
tfBuildProvider.IsRunningOnAzurePipelinesHosted.Returns(true);
tfBuildProvider.Environment.Returns(tfBuildEnvironment);

// When
var buildSystem = new BuildSystem(appVeyorProvider, teamCityProvider, myGetProvider, bambooProvider, continuaCIProvider, jenkinsProvider, bitriseProvider, travisCIProvider, bitbucketPipelinesProvider, goCDProvider, gitLabCIProvider, tfBuildProvider, gitHubActionsProvider, azurePipelinesProvider);
Expand Down

0 comments on commit 1e3c6de

Please sign in to comment.