Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TFBuild alias to AzurePipelines #2658

Closed
pascalberger opened this issue Nov 5, 2019 · 6 comments
Closed

Rename TFBuild alias to AzurePipelines #2658

pascalberger opened this issue Nov 5, 2019 · 6 comments
Assignees
@Marusyk
Labels
Improvement
Milestone
v0.38.0

Comments

@pascalberger
Copy link
Member

What You Are Seeing?

With the rename of Visual Studio Team Services / Team Foundation Server to Azure DevOps, the TFBuild alias doesn't fit anymore.

What is Expected?

The alias should be called AzurePipelines instead. Classes should also be renamed. To be backwards compatible we can mark the existing TFBuild alias as obsolete. Additionaly we might want to remove obsolete members from the new alias / classes.

What version of Cake are you using?

0.35.0

Are you running on a 32 or 64 bit system?

N/A

What environment are you running on? Windows? Linux? Mac?

N/A

Are you running on a CI Server? If so, which one?

Azure Pipelines
@Marusyk
Copy link
Contributor

Marusyk commented Nov 27, 2019

Can I take this one?

@patriksvensson
Copy link
Member

@Marusyk Sure! Make sure that you keep the existing aliases and mark them as obsolete so we're backwards compatible and doesn't break anyone's builds. You can find other examples of this in the code base. If you got any questions, feel free to reach out.

Marusyk added a commit to Marusyk/cake that referenced this issue Dec 8, 2019
@Marusyk
Add AzurePipelines alias. cake-build#2658
ed5a81d
@Marusyk
Copy link
Contributor

Marusyk commented Dec 10, 2019

Hello @patriksvensson
Could you please give me some clarification?

  1. Copy TFBuild alias folder and rename it to AzurePipelines
  2. The TFBuild don't remove, just mark it as obsolete
  3. Add the AzurePipelines to BuildSystem and BuildSystemAliases
  4. All tests duplicate to AzurePipelines

What do you think about it?
Thank you in advance

@Marusyk
Copy link
Contributor

Marusyk commented Jan 5, 2020

Hello @patriksvensson
it would be great to have any comments from you

@patriksvensson
Copy link
Member

@Marusyk Sorry for the late reply. Missed this somehow...

Yes, sounds like a good idea!

@Marusyk Marusyk mentioned this issue Mar 2, 2020
Merged
Marusyk added a commit to Marusyk/cake that referenced this issue Mar 3, 2020
@Marusyk
Add AzurePipelines alias. cake-build#2658
159829e
@devlead devlead added this to the v1.0.0 milestone May 14, 2020
@gep13 gep13 modified the milestones: v1.0.0, v0.38.0 May 19, 2020
gep13 pushed a commit to Marusyk/cake that referenced this issue May 19, 2020
@Marusyk @gep13
Add AzurePipelines alias. cake-build#2658
3078796
gep13 added a commit to Marusyk/cake that referenced this issue May 19, 2020
@gep13
(cake-buildGH-2658) Fix stylecop error
a16a5d4
gep13 added a commit to Marusyk/cake that referenced this issue May 19, 2020
@gep13
(cake-buildGH-2658) Update unit tests
bc3d49c 
Some tests were failing as a result of the changes.  Updated to
Substitute additional required items.
devlead pushed a commit to Marusyk/cake that referenced this issue May 19, 2020
@Marusyk @devlead
Add AzurePipelines alias. cake-build#2658
f7d192b
devlead pushed a commit to Marusyk/cake that referenced this issue May 19, 2020
@gep13 @devlead
(cake-buildGH-2658) Fix stylecop error
719e2df
devlead pushed a commit to Marusyk/cake that referenced this issue May 19, 2020
@gep13 @devlead
(cake-buildGH-2658) Update unit tests
1e3c6de 
Some tests were failing as a result of the changes.  Updated to
Substitute additional required items.
devlead pushed a commit to Marusyk/cake that referenced this issue May 20, 2020
@Marusyk @devlead
Add AzurePipelines alias. cake-build#2658
73d50a9
devlead pushed a commit to Marusyk/cake that referenced this issue May 20, 2020
@gep13 @devlead
(cake-buildGH-2658) Fix stylecop error
2e4ca87
devlead pushed a commit to Marusyk/cake that referenced this issue May 20, 2020
@gep13 @devlead
(cake-buildGH-2658) Update unit tests
41731a7 
Some tests were failing as a result of the changes.  Updated to
Substitute additional required items.
gep13 pushed a commit to Marusyk/cake that referenced this issue May 29, 2020
@Marusyk @gep13
Add AzurePipelines alias. cake-build#2658
8fd5fbc
gep13 added a commit to Marusyk/cake that referenced this issue May 29, 2020
@gep13
(cake-buildGH-2658) Fix stylecop error
ae7c452
gep13 added a commit to Marusyk/cake that referenced this issue May 29, 2020
@gep13
(cake-buildGH-2658) Update unit tests
2afecf3 
Some tests were failing as a result of the changes.  Updated to
Substitute additional required items.
gep13 added a commit to Marusyk/cake that referenced this issue May 29, 2020
@gep13 @pascalberger
(cake-buildGH-2658) Update docs
3580de2 
Replacing all mention of TFBuild with AzurePipelines.

Co-authored-by: Pascal Berger <[email protected]>
pascalberger added a commit to Marusyk/cake that referenced this issue May 29, 2020
@pascalberger
(cake-buildGH-2658) Make BuildSystem.TFBuild obsolete
4084937
pascalberger added a commit to Marusyk/cake that referenced this issue May 29, 2020
@pascalberger
(cake-buildGH-2658) Make BuildSystem.TFBuild obsolete
697a823
@gep13 gep13 closed this as completed May 30, 2020
gep13 added a commit that referenced this issue May 30, 2020
@gep13
Merge branch 'release/0.38.0' into main
ea88e05 
* release/0.38.0: (48 commits)
  (build) Updated version and release notes.
  (GH-2658) Make BuildSystem.TFBuild obsolete
  (GH-2658) Update docs
  (GH-2658) Update unit tests
  (GH-2658) Fix stylecop error
  Add AzurePipelines alias. #2658
  (GH-2785) Add debug logs for when resolving tools
  Added NugetDelete function to Cake.Common.Tools.Nuget
  (doc) Add Enrico to author/copyright info
  (GH-2778) Update Roslyn to 3.6.0 * fixes #2778
  Bump .NET Core SDK to 3.1.300
  Diagnostic integration tests
  Add ANSI terminal support to log
  Added tests for Cake.Core.IO
  Revert GitVersion.Tool to 5.1.2
  Bump script dependencies
  (GH-2735) Improve documentation to make clear that project can be passed to MsBuild alias
  Skip-Option properly named: SkipOutputAnalysis.
  Added options to skip the analysis of the output file
  Add integration test for nuget setapikey
  ...
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v0.38.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@Marusyk Marusyk mentioned this issue May 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marusyk Marusyk

Labels
Improvement
Projects
None yet
Milestone
v0.38.0
Development

No branches or pull requests
6 participants
@patriksvensson @gep13 @devlead @pascalberger @Marusyk @cake-build-bot