This repository has been archived by the owner on Aug 27, 2024. It is now read-only.
Fix incorrect display of subtitle track list when using mpc-hc as player #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢 PR，工作日没时间看，周末会看的 |
收到，感谢回复。工作辛苦，您先忙 |
Masaiki
reviewed
Nov 25, 2023
Masaiki
reviewed
Nov 25, 2023
Masaiki
reviewed
Nov 25, 2023
|
总体上没什么问题，辛苦了 |
|
Close #16 |
ok，已修正出现的问题 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本来我是在mpc-hc那里改的，今天早上起来我又想了想，觉得还是在xySubFilter这里改可能好点。理由如下：
CSimpleTextSubtitle的m_name处理的似乎有问题，为了能把字幕名称完整地显示出来，我对CSimpleTextSubtitle::Open做了点改动。现在m_name存储的是字幕文件名，至于XySubFilter::get_LanguageName，我直接让他在拿到文件名之后再找有没有表示字幕语言的部分了。为了能在XySubFilter::Info里拿到m_name，我还在XySubFilter::GetIsEmbeddedSubStream下面加了一个新函数：XySubFilter::GetSubStreamName（不过我感觉这个函数加的不是很妥当，或许有更好的解决方法？）最终效果如下：
不知道这样的改动可不可行呢？