Fix pipe not aborting when both preventAbort and preventCancel are set #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiasBuelens
added
bug
domain: compliance
MattiasBuelens
deleted the
fix-pipe-abort-with-preventcancel-and-preventabort
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the specification for "wait for all" (w3ctag/promises-guide#58), which also ended up in the streams reference implementation and hence this polyfill. See whatwg/streams#1006 for details.
I initially ported the fix of whatwg/streams#1006 as-is to the polyfill, but then I realized that we might as well use the native
Promise.allto implement the "wait for all" helper. That simplifies the code quite a bit. 🙂