Fix pipe not aborting when both preventAbort and preventCancel are set #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiasBuelens
added a commit
to MattiasBuelens/web-streams-polyfill
that referenced
this pull request
Jul 12, 2019
|
See my comment at w3ctag/promises-guide#58 (comment) about whether or not successSteps is called synchronously. We should probably make this match whatever resolution we choose there. |
|
We can use https://nodejs.org/dist/latest-v12.x/docs/api/globals.html#globals_queuemicrotask_callback / https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/queueMicrotask to implement the promises guide revision. |
|
Looks like jsdom doesn't expose const failures = await wptRunner(testsPath, {
rootURL: 'streams/',
setup(window) {
window.queueMicrotask = queueMicrotask;
window.eval(bundledJS);
},
// ...
}); |
|
Bah, yeah, that's probably simplest for now. |
When both flags are set, the abortAlgorithm passes an empty list of actions to "wait for all". This helper should immediately resolve the returned promise when no promises are given, but instead the promise remained pending forever. Fix it.
MattiasBuelens
force-pushed
the
fix-pipe-abort-with-preventcancel-and-preventabort
branch
from
bbafe17
to
a9a6341
Compare
MattiasBuelens
deleted the
fix-pipe-abort-with-preventcancel-and-preventabort
branch
MattiasBuelens
added a commit
to MattiasBuelens/web-streams-polyfill
that referenced
this pull request
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both flags are set, the abortAlgorithm passes an empty list of actions to "wait for all". This helper should immediately resolve the returned promise when no promises are given, but instead the promise remained pending forever.
This fixes the reference implementation of the "wait for all" helper to resolve correctly when given an empty list of promises. This matches the spec change in w3ctag/promises-guide#58.
Originally reported in this comment on #1004.
WPT: web-platform-tests/wpt#17816