Deleted StratConSkillGenerator.java
#6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `StratConSkillGenerator` with `ModifiedConstantSkillGenerator` in `AtBDynamicScenarioFactory`. Introduced skill level adjustments based on dice rolls and added a new method in `SkillLevel` to parse integer values to skill levels.
Removed `StratConSkillGenerator.java` as it is no longer needed. This file contained methods for generating random skills. I found I could achieve the same goal better using `ModifiedConstantSkillGenerator.java`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6046 +/- ##
============================================
- Coverage 29.10% 29.10% -0.01%
+ Complexity 13977 13975 -2
============================================
Files 2580 2579 -1
Lines 267165 267184 +19
Branches 47717 47723 +6
============================================
- Hits 77756 77753 -3
- Misses 185505 185529 +24
+ Partials 3904 3902 -2 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
StratConSkillGenerator.javaas it is no longer needed. This file contained methods for generating random skills. I found I could achieve the same goal better usingModifiedConstantSkillGenerator.java.Introduced skill level adjustments based on dice rolls and added a new method in
SkillLevelto parse integer values to skill levels.This is the MM half of #4937