Added Contract Difficulty Estimate, Including GUI Support #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the `AtBContract` class to include methods for calculating and displaying contract difficulty. Added UI elements in `ContractMarketDialog` and `ContractSummaryPanel` to show difficulty estimates. Added dialog calls for when the player is picking unusually easy or overly challenging contracts. Enhanced code maintainability by removing a long switch statement for faction logos and replaced it with a function call. Expanded the switch to include all factions we have logos for, and not just the Clan factions.
Replaced the use of sanitized faction codes with original faction codes for calculating enemy and ally power. Removed the redundant `sanitizeFactionCode` method to simplify the codebase. Additionally, streamlined error handling and improved UI messages for mission challenges for better readability.
…rketDialog. Updated difficulty conditional checks to ensure consistency and correct evaluation across `AtBContract.java` and `ContractMarketDialog.java`. This includes modifying threshold values and conditional logic for image selection and message determination.
Replaced the StratConSkillGenerator with ModifiedConstantSkillGenerator for skill generation. This adjustment aimed to achieve more consistent and predictable skill levels during mission setup.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4943 +/- ##
============================================
- Coverage 10.45% 10.42% -0.03%
+ Complexity 6013 6003 -10
============================================
Files 951 951
Lines 132877 133139 +262
Branches 19330 19380 +50
============================================
- Hits 13891 13886 -5
- Misses 117637 117903 +266
- Partials 1349 1350 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #6046 (tests will fail until that PR is merged)
Refactored the
AtBContractclass to include methods for calculating and displaying contract difficulty. Added UI elements inContractMarketDialogandContractSummaryPanelto show difficulty estimates.Added dialog calls for when the player is picking unusually easy or overly challenging contracts.
Enhanced code maintainability by removing a long switch statement for faction logos and replaced it with a function call. Expanded the switch to include all factions we have logos for, and not just the Clan factions.