feat: ✨ add maxLength to schema
#485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the column has a length (e.g. varchar(256), propagate this length to maxLength in the schema. This can then be used in sql targets to create columns with the right type and size.
tobiascadee
force-pushed
the
tobias/add-maxLength-to-discovered-schema-#477
branch
from
ac003a9
to
bd09bf4
Compare
|
great feature @edgarrmondragon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the column has a length (e.g. varchar(256), propagate this length to maxLength in the schema. This can then be used in sql targets to create columns with the right type and size.
this is PR for this issue: #477