Skip to content

Commit

Permalink
Update version and changelog with v5.0.1 release (#79)
Browse files Browse the repository at this point in the history
* Don't fail overall if Slack announcement fails (#69)

Typically, for a project, this action is run twice: once in dry-run mode
(to allow approvers to review the package before it is published) and
another time to issue the approval step and then actually publish the
package.

When the action is run in dry-run mode, an announcement on Slack is
created in order to notify approvers. If this fails in any way, however,
it halts the release workflow completely and prevents the second
instance of the action from running. This means that the package can
never be released automatically and must be released manually.

This commit fix this problem by instructing GitHub Actions that it is
not mandatory for the Slack announcement step to pass in order for the
release workflow to continue.

* Release 5.0.1 (#71)

---------

Co-authored-by: Elliot Winkler <[email protected]>
  • Loading branch information
Gudahtt and mcmire authored May 10, 2024
1 parent 2d0ccb5 commit 926f159
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [5.0.1]
### Fixed
- Prevent workflow from failing if Slack announcement step fails ([#69](https://github.com/MetaMask/action-npm-publish/pull/69))
- Within the context of a project, the Slack announcement message that is posted after running this workflow in dry-run mode is not crucial, and thus this change ensures that the package will still be published for real if this step fails.

## [5.0.0]
### Changed
- **BREAKING:** Disallow publishing packages with version 0.0.0 ([#63](https://github.com/MetaMask/action-npm-publish/pull/63))
Expand Down Expand Up @@ -95,7 +100,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Initial release ([#1](https://github.com/MetaMask/action-npm-publish/pull/1))

[Unreleased]: https://github.com/MetaMask/action-npm-publish/compare/v5.0.0...HEAD
[Unreleased]: https://github.com/MetaMask/action-npm-publish/compare/v5.0.1...HEAD
[5.0.1]: https://github.com/MetaMask/action-npm-publish/compare/v5.0.0...v5.0.1
[5.0.0]: https://github.com/MetaMask/action-npm-publish/compare/v4.0.4...v5.0.0
[4.0.4]: https://github.com/MetaMask/action-npm-publish/compare/v4.0.3...v4.0.4
[4.0.3]: https://github.com/MetaMask/action-npm-publish/compare/v4.0.2...v4.0.3
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"url": "https://github.com/MetaMask/action-npm-publish/issues"
},
"homepage": "https://github.com/MetaMask/action-npm-publish#readme",
"version": "5.0.0",
"version": "5.0.1",
"main": "index.js",
"directories": {
"test": "test"
Expand Down

0 comments on commit 926f159

Please sign in to comment.