Add npm Publish #43
Merged
Add npm Publish #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
commented
Jan 27, 2022
rickycodes
commented
Jan 27, 2022
rekmarks
requested changes
Jan 27, 2022
action.yml
Outdated
Comment on lines
38
to
40
| - id: Setup | ||
| shell: bash | ||
| run: ${{ github.action_path }}/scripts/yarn-setup.sh |
There was a problem hiding this comment.
This step and yarn-setup.sh should be deleted. The following lines should be added to the publish-release workflow to ensure that everything is set up properly:
There was a problem hiding this comment.
the publish-release workflow in all repositories where we want to publish to npm*
Most especially, we should do this in the module template repository.
rekmarks
reviewed
Jan 28, 2022
rekmarks
reviewed
Jan 28, 2022
|
Ok! I think this should be good meow |
rickycodes
commented
Jan 28, 2022
rickycodes
added a commit
that referenced
this pull request
Feb 25, 2022
This reverts commit 7b7e195.
Merged
rickycodes
added a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #2
and I guess MetaMask/metamask-module-template#31 (comment) also
I've tested this out in my fork of controllers: https://github.com/rickycodes/controllers/runs/4960993990?check_suite_focus=true