Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add npm Publish" #44

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Revert "Add npm Publish" #44

merged 1 commit into from
Feb 25, 2022

Conversation

rickycodes
Copy link
Contributor

@rickycodes rickycodes commented Feb 25, 2022

turns out we have to separate npm publishing from action-publish-release after all. there was a requirement from the security team that building and publishing happen in isolated environments. so, instead of publishing here we've created: http://github.com/MetaMask/action-npm-publish

Reverts #43

@rickycodes rickycodes requested a review from a team as a code owner February 25, 2022 19:16
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rickycodes rickycodes merged commit 884b8ba into main Feb 25, 2022
@rickycodes rickycodes deleted the revert-43-feature/npm-publish branch February 25, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants