Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[assets-contract-controller] Apply messenger pattern and remove inheritance from BaseControllerV1 #4397

Merged
merged 44 commits into from
Jul 19, 2024
Merged

[assets-contract-controller] Apply messenger pattern and remove inheritance from BaseControllerV1 #4397

Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
5288605
Convert `AssetsContractController` to use messenger pattern without i…
MajorLift Jun 11, 2024
7886280
Fix method returning promise into async function
MajorLift Jun 11, 2024
7b2ed46
Explicitly enumerate package-level exports
MajorLift Jun 11, 2024
fa059a9
Adapt tests to use messenger pattern
MajorLift Jun 11, 2024
27f6f88
Narrow iindex signature of `SINGLE_CALL_BALANCES_ADDRESS_BY_CHAINID`
MajorLift Jun 11, 2024
c6a9323
Define messenger actions corresponding to the public methods of `Asse…
MajorLift Jul 10, 2024
35a3bf9
Convert getters for `provider`, `chainId` into private methods
MajorLift Jun 13, 2024
4c37cfe
Register action handlers
MajorLift Jun 13, 2024
79a29c3
Replace AssetsContractController constructor options with messenger a…
MajorLift Jul 10, 2024
1315c88
Linter fix
MajorLift Jun 13, 2024
83271e7
Convert class methods into messenger actions
MajorLift Jul 10, 2024
123fe80
Register class methods as action handlers
MajorLift Jun 26, 2024
ee3a923
Add assets-contract actions as allowed actions to downstream controllers
MajorLift Jun 26, 2024
10a4678
[assets-contract] Adjust downstream tests to use messenger actions in…
MajorLift Jun 27, 2024
39ac871
Pass callbacks into `expect`
MajorLift Jul 2, 2024
3964cb1
Fix `setupAssetContractControllers` so that `useNetworkControllerProv…
MajorLift Jul 11, 2024
079f4cd
Make class fields accessible but immutable by converting to private b…
MajorLift Jul 11, 2024
f1f58e7
fix `NftController` test mock action handlers to be excluded from `op…
MajorLift Jul 11, 2024
2de5258
Replace references to `NetworkController:stateChange` event with `Net…
MajorLift Jul 14, 2024
69ba701
Fix `#getCorrect{Provider,ChainId}` methods so that the methods retur…
MajorLift Jul 16, 2024
a258fa2
Fix `setupAssetContractControllers`, revert unintended changes to `us…
MajorLift Jul 16, 2024
bbb0b0f
Clean up `AssetsContractController` tests
MajorLift Jul 16, 2024
30d2f29
Fix `BN.isZero()` call that throws error, causing ERC-1155 ownership …
MajorLift Jul 16, 2024
38fb163
Fix `NftController` `watchNft` test errors caused by changes to `mess…
MajorLift Jul 16, 2024
1559242
Set `ApprovalController:addRequest` payload `requestData.asset.standa…
MajorLift Jul 16, 2024
ed70562
Fix async `expect.rejects.toThrow` call so that the `expect` call is …
MajorLift Jul 16, 2024
ffa8cb3
Update coverage thresholds
MajorLift Jul 16, 2024
022b3ff
Add `eslint-disable` directive to prevent test from timing out
MajorLift Jul 16, 2024
18cc886
Adapt `watchNft` tests to new messenger call invocations
MajorLift Jul 16, 2024
c445384
Use `getKnownPropertyNames` for iterative `registerActionHandlers` logic
MajorLift Jul 16, 2024
056e8dc
Revert unnecessary changes
MajorLift Jul 16, 2024
99fc5b9
Remove unreleased changelog entries
MajorLift Jul 16, 2024
6c6f6e5
Convert `provider` setter into `setProvider` method
MajorLift Jul 16, 2024
20e5451
Add jsdoc for `AssetsContractController` types
MajorLift Jul 16, 2024
1d5ea66
Fix `#registerActionHandlers`
MajorLift Jul 16, 2024
236844a
test(nft-controller): fix messenger call mocks
MajorLift Jul 16, 2024
a40f0d1
test(nft-controller): expose mock constructors for allowedActions
MajorLift Jul 17, 2024
161b7ce
Merge branch 'main' into 240610-upgrade-AssetsContractController
MajorLift Jul 17, 2024
f50e5f4
Rename variable for clarity
MajorLift Jul 17, 2024
418df79
Remove getter for `provider`
MajorLift Jul 17, 2024
c35943c
Merge branch 'main' into 240610-upgrade-AssetsContractController
MajorLift Jul 17, 2024
49831d9
Apply `ExtractAvailable{Action,Event}` test utility types
MajorLift Jul 17, 2024
e6324d9
Merge branch 'main' into 240610-upgrade-AssetsContractController
MajorLift Jul 18, 2024
b496b69
Merge branch 'main' into 240610-upgrade-AssetsContractController
MajorLift Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/assets-controllers/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ module.exports = merge(baseConfig, {
// An object that configures minimum threshold enforcement for coverage results
coverageThreshold: {
global: {
branches: 90.35,
functions: 96.74,
lines: 97.34,
statements: 97.36,
branches: 91.07,
functions: 97.51,
lines: 98.12,
statements: 98.03,
},
},

Expand Down
Loading
Loading