Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.0.0 #316

Merged
merged 3 commits into from
Jun 30, 2023
Merged

6.0.0 #316

merged 3 commits into from
Jun 30, 2023

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 6.0.0.

@mikesposito
Copy link
Member

We may wait for #306 as it is also breaking
cc. @legobeat

@mikesposito mikesposito marked this pull request as ready for review June 26, 2023 09:15
@mikesposito mikesposito requested a review from a team as a code owner June 26, 2023 09:16
Gudahtt
Gudahtt reviewed Jun 29, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Gudahtt
Copy link
Member

Gudahtt commented Jun 29, 2023

What affect do we anticipate this breaking change having upon us? Specifically our dapp API. I'm wondering if this will have an impact that we'll have to prevent using an adapter, or prepare messaging about.

@mikesposito
Copy link
Member

mikesposito commented Jun 29, 2023 •
edited
Loading

Before @metamask/[email protected] the data parameter was never normalized when signing a personal message. Since 11.0.0 this line has been added, so I guess the behavior will change already when introducing the new @metamask/eth-keyring-controller into @metamask/keyring-controller, regardless of the fix introduced with this release.
This release is actually trying to keep the behavior closer (or the same?) to how it was before

@Gudahtt
Copy link
Member

Gudahtt commented Jun 30, 2023

I found one usage in this repository, but it seems to have no functional impact in that case because it's only used for numbers and it had zero-padding already.

I cant find any other cases. I think you're right. This looks good.

Gudahtt
Gudahtt approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito merged commit 1f8be1e into main Jun 30, 2023
21 checks passed
@mikesposito mikesposito deleted the release/6.0.0 branch June 30, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikesposito @Gudahtt