fix: return "0x00" for normalize(0)

[legobeat]

The normalize function returns 0x${number} for all numbers except 0, for which it returns undefined. This changes it to return 0x00 for 0.

[legobeat]

@adonesky1 @kumavis This stood out to me. Do you recall the context on why this returns 0x for all negative numbers instead of throwing like it does on other invalid input?
1e4f176#diff-39b2554fd18da165b59a6351b1aafff3714e2a80c1435f2de9706355b4d32351R111

[legobeat]

Ah, I guess the intention is to throw on negative numbers.

eth-sig-util/src/utils.test.ts

Line 120 in f33a032

// TODO: Add validation to disallow negative integers.

I can address that in a separate change (as it's a breaking one) after this one has been merged and released.

[kumavis]

good

this is a breaking change

[Gudahtt]

LGTM!

[legobeat]

Not certain if this should be merged and released before or after #273.

[mikesposito]

I didn't notice this PR before opening this one: #315
@legobeat I am thinking if maybe #315 could solve the problem you are trying to fix?

[mcmire]

@mikesposito @legobeat This seems complementary to #315. There would be conflicts whether we merge one first or the other, but I don't see a reason why we couldn't have both. Do you?

[mcmire]

Makes sense.

[mikesposito]

@mcmire We can definitely have both, I was just pointing out that after #315 has been merged, the early function termination does not affect 0 as input anymore, so from this PR we could also just add the test

[Gudahtt]

I don't think the functional change made in this PR is relevant anymore. The change in #315 is functionally equivalent in the case where zero is passed in, though broader in that it also affects the case where an empty string is passed in.

Agreed that the test would be useful to include though!

[Gudahtt]

I have created a separate PR to add just the test: #317

[Gudahtt]

Superseded by #315 and #317