Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for normalizing zero #317

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Add test for normalizing zero #317

merged 1 commit into from
Jun 29, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 29, 2023

A test has been added to capture the behavior of the normalize function when a zero is passed in. This behavior changed recently in PR #315.

A test has been added to capture the behavior of the `normalize`
function when a zero is passed in. This behavior changed recently in
PR #315.
@Gudahtt Gudahtt requested a review from a team as a code owner June 29, 2023 12:51
@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 29, 2023

This test was ported from #306

Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 4b84549 into main Jun 29, 2023
@Gudahtt Gudahtt deleted the add-test-for-zero-input branch June 29, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants