Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple key value component #11428

Closed
jpuri opened this issue Sep 25, 2024 · 0 comments · Fixed by #11497
Closed

Simple key value component #11428

jpuri opened this issue Sep 25, 2024 · 0 comments · Fixed by #11497
Assignees
@jpuri
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-confirmations Push issues to confirmations team

Comments

@jpuri
Copy link
Contributor

jpuri commented Sep 25, 2024 •
edited
Loading

Create simple key-> value component for mobile where both key and value ans simple text strings. Key can optionally have a tooltip.

Screenshot 2024-09-25 at 5 23 48 PM

Figma: https://www.figma.com/design/CeAIcptzeaI5ciTpYBaiqr/Confirmations-DS?node-id=4314-18587&node-type=canvas&t=FTDELWNrSVJ25uB6-0

If text is very long it should wrap as below:

Screenshot 2024-09-25 at 5 23 57 PM
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Sep 25, 2024
@jpuri jpuri added the team-confirmations Push issues to confirmations team label Sep 25, 2024
@jpuri jpuri changed the title Mobile redesign Simple key value component Sep 25, 2024
@jpuri jpuri assigned jpuri and unassigned jpuri Sep 25, 2024
@jpuri jpuri mentioned this issue Sep 30, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2024
@jpuri
feat: simple key-> value component for text value type (#11497)
7e91585 
## **Description**

Adding simple key-> value component for text value type

## **Related issues**

Fixes: #11428

## **Manual testing steps**

1. Start storybook locally
2. Check InfoRow component

## **Screenshots/Recordings**
<img width="414" alt="Screenshot 2024-09-30 at 9 00 55 PM"
src="https://github.com/user-attachments/assets/2e74b828-cd6e-47fb-94d7-9a8a72389d9f">

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: simple key-> value component for text value type MetaMask/metamask-mobile
2 participants
@jpuri @metamaskbot