Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simple key-> value component for text value type #11497

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 30, 2024

Description

Adding simple key-> value component for text value type

Related issues

Fixes: #11428

Manual testing steps

  1. Start storybook locally
  2. Check InfoRow component

Screenshots/Recordings

Screenshot 2024-09-30 at 9 00 55 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team labels Sep 30, 2024
@jpuri jpuri requested review from a team as code owners September 30, 2024 14:48
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Sep 30, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bd44689
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f147ca1c-b006-433f-8568-051e0356460c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 30, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a2d80d8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/43f92e7d-1abf-4578-80a9-b6ae1d22856f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 1, 2024
@jpuri jpuri enabled auto-merge October 1, 2024 09:35
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 88688cc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7e5f7c46-2bde-4cf6-9e32-2f2f81adf90e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 1, 2024
@jpuri jpuri disabled auto-merge October 1, 2024 13:27
@jpuri jpuri enabled auto-merge October 1, 2024 13:28
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 011ea64
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1dae53b6-9a1a-426d-b159-fc52ca41fc5c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3b9a7d8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/448bb2d8-06e5-4956-a8ff-736e3747196a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 33a48a0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/edc1ee94-a820-4bbb-87c9-75afc6a34e1b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Oct 2, 2024

@tommasini tommasini removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 2, 2024
@jpuri jpuri added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 7e91585 Oct 2, 2024
45 of 46 checks passed
@jpuri jpuri deleted the key_value_component branch October 2, 2024 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Simple key value component
5 participants