[Bug]: Android system alerts do not change when switching from light to dark mode unless force closed #11553
Labels
area-design
Design bug (previously known as papercuts - ask Hilary for more detail)
regression-prod-7.32.0
Regression bug that was found in production in release 7.32.0
Sev3-low
A possible confusion or deception that is only hypothetical & has no known instances in the wild
team-design-system
All issues relating to design system in Mobile
team-wallet-ux
type-bug
Something isn't working
Comments
metamaskbot
added
the
regression-prod-7.32.0
vinnyhoward
added
Sev3-low
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 1, 2024
## **Description** In android our system alerts do not respect our dark mode themes as they should. KNOWN BUG: When switching from light mode to dark mode the changes to Android system alerts do not happen. The user is forced to close the app and reopen and the alerts will be in dark mode. However switching from dark to light mode is fine. Would love feedback on how to solve this issue I've created an issue for this bug [here](#11553) ## **Related issues** Fixes: [#11481](#11481) ## **Manual testing steps** 1. Make sure you're using an Android device, rebuild or reinstall a fresh app to make sure the changes are there. 2. Goto Android system settings and select light mode 3. Goto the MetaMask wallet home page 4. Click on the QR code on the top right 5. Scan an invalid QR code 6. See that the system alert is white background with black text 7. Go to the Android settings and change it to dark mode 8. Go back to the MetaMask app and scan the invalid QR code again, you should see a dark alert with white text. If not force close the app and reopen and the changes will take place ## **Screenshots/Recordings** NA ### **Before** | Dark Mode (broken) | Light Mode (not broken) |:---:|:---:| |||| ### **After** | Dark Mode | Light Mode | |:---:|:---:| |]|| ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
added a commit
that referenced
this issue
Oct 1, 2024
## **Description** In android our system alerts do not respect our dark mode themes as they should. KNOWN BUG: When switching from light mode to dark mode the changes to Android system alerts do not happen. The user is forced to close the app and reopen and the alerts will be in dark mode. However switching from dark to light mode is fine. Would love feedback on how to solve this issue I've created an issue for this bug [here](#11553) ## **Related issues** Fixes: [#11481](#11481) ## **Manual testing steps** 1. Make sure you're using an Android device, rebuild or reinstall a fresh app to make sure the changes are there. 2. Goto Android system settings and select light mode 3. Goto the MetaMask wallet home page 4. Click on the QR code on the top right 5. Scan an invalid QR code 6. See that the system alert is white background with black text 7. Go to the Android settings and change it to dark mode 8. Go back to the MetaMask app and scan the invalid QR code again, you should see a dark alert with white text. If not force close the app and reopen and the changes will take place ## **Screenshots/Recordings** NA ### **Before** | Dark Mode (broken) | Light Mode (not broken) |:---:|:---:| |||| ### **After** | Dark Mode | Light Mode | |:---:|:---:| |]|| ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
added a commit
that referenced
this issue
Oct 1, 2024
## **Description** In android our system alerts do not respect our dark mode themes as they should. KNOWN BUG: When switching from light mode to dark mode the changes to Android system alerts do not happen. The user is forced to close the app and reopen and the alerts will be in dark mode. However switching from dark to light mode is fine. Would love feedback on how to solve this issue I've created an issue for this bug [here](#11553) ## **Related issues** Fixes: [#11481](#11481) ## **Manual testing steps** 1. Make sure you're using an Android device, rebuild or reinstall a fresh app to make sure the changes are there. 2. Goto Android system settings and select light mode 3. Goto the MetaMask wallet home page 4. Click on the QR code on the top right 5. Scan an invalid QR code 6. See that the system alert is white background with black text 7. Go to the Android settings and change it to dark mode 8. Go back to the MetaMask app and scan the invalid QR code again, you should see a dark alert with white text. If not force close the app and reopen and the changes will take place ## **Screenshots/Recordings** NA ### **Before** | Dark Mode (broken) | Light Mode (not broken) |:---:|:---:| |||| ### **After** | Dark Mode | Light Mode | |:---:|:---:| |]|| ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
pushed a commit
that referenced
this issue
Oct 1, 2024
…dark mode themes (#11552) ## **Description** In android our system alerts do not respect our dark mode themes as they should. KNOWN BUG: When switching from light mode to dark mode the changes to Android system alerts do not happen. The user is forced to close the app and reopen and the alerts will be in dark mode. However switching from dark to light mode is fine. Would love feedback on how to solve this issue I've created an issue for this bug [here](#11553) ## **Related issues** Fixes: [#11481](#11481) ## **Manual testing steps** 1. Make sure you're using an Android device, rebuild or reinstall a fresh app to make sure the changes are there. 2. Goto Android system settings and select light mode 3. Goto the MetaMask wallet home page 4. Click on the QR code on the top right 5. Scan an invalid QR code 6. See that the system alert is white background with black text 7. Go to the Android settings and change it to dark mode 8. Go back to the MetaMask app and scan the invalid QR code again, you should see a dark alert with white text. If not force close the app and reopen and the changes will take place ## **Screenshots/Recordings** NA ### **Before** | Dark Mode (broken) | Light Mode (not broken) |:---:|:---:| |||| ### **After** | Dark Mode | Light Mode | |:---:|:---:| |]|| ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
7 tasks
Cal-L
pushed a commit
that referenced
this issue
Oct 1, 2024
…dark mode themes (#11555) - fix(11481): android system alert respects dark mode themes (#11552) ## **Description** In android our system alerts do not respect our dark mode themes as they should. KNOWN BUG: When switching from light mode to dark mode the changes to Android system alerts do not happen. The user is forced to close the app and reopen and the alerts will be in dark mode. However switching from dark to light mode is fine. Would love feedback on how to solve this issue I've created an issue for this bug [here](#11553) ## **Related issues** Fixes: [#11481](#11481) ## **Manual testing steps** 1. Make sure you're using an Android device, rebuild or reinstall a fresh app to make sure the changes are there. 2. Goto Android system settings and select light mode 3. Goto the MetaMask wallet home page 4. Click on the QR code on the top right 5. Scan an invalid QR code 6. See that the system alert is white background with black text 7. Go to the Android settings and change it to dark mode 8. Go back to the MetaMask app and scan the invalid QR code again, you should see a dark alert with white text. If not force close the app and reopen and the changes will take place ## **Screenshots/Recordings** NA ### **Before** | Dark Mode (broken) | Light Mode (not broken) |:---:|:---:| |||| ### **After** | Dark Mode | Light Mode | |:---:|:---:| |]|| ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [95f9a91](95f9a91) Co-authored-by: Vince Howard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
This is a follow up for this pull request relating to this issue. When the user toggles dark mode the Android system alerts modals do not inherit the changes and the user is forced to force close the application and reopen. Once reopened the alerts inherit the dark mode changes.
I have seen this happen in reverse once but could not replicate. But force closing and reopening solves the issue as well
Expected behavior
When toggling to dark mode in Android system settings the system alerts in the app should change colors
Screenshots/Recordings
https://drive.google.com/file/d/130Yb9jNXkNEx1qQGXGDx_A_tXynUkKbh/view?usp=drive_link
Steps to reproduce
Error messages or log output
No response
Detection stage
In production (default)
Version
7.32.0
Build type
None
Device
Any device
Operating system
Android
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: