Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(11481): android system alert respects dark mode themes #11552

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Oct 1, 2024

Description

In android our system alerts do not respect our dark mode themes as they should.

KNOWN BUG:
When switching from light mode to dark mode the changes to Android system alerts do not happen. The user is forced to close the app and reopen and the alerts will be in dark mode. However switching from dark to light mode is fine.
Would love feedback on how to solve this issue

I've created an issue for this bug here

Related issues

Fixes: #11481

Manual testing steps

  1. Make sure you're using an Android device, rebuild or reinstall a fresh app to make sure the changes are there.
  2. Goto Android system settings and select light mode
  3. Goto the MetaMask wallet home page
  4. Click on the QR code on the top right
  5. Scan an invalid QR code
  6. See that the system alert is white background with black text
  7. Go to the Android settings and change it to dark mode
  8. Go back to the MetaMask app and scan the invalid QR code again, you should see a dark alert with white text. If not force close the app and reopen and the changes will take place

Screenshots/Recordings

NA

Before

Dark Mode (broken) Light Mode (not broken)
Screenshot_1727810220 Screenshot_1727809386

After

Dark Mode Light Mode
darkmode] Screenshot_1727809386

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Oct 1, 2024
@vinnyhoward vinnyhoward requested a review from a team as a code owner October 1, 2024 19:23
Copy link
Contributor

github-actions bot commented Oct 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: add5d85
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1aa2288-3172-47ab-b3f8-144826bfaeb1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added team-design-system All issues relating to design system in Mobile area-design Design bug (previously known as papercuts - ask Hilary for more detail) labels Oct 1, 2024
Cal-L
Cal-L previously approved these changes Oct 1, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added this pull request to the merge queue Oct 1, 2024
@Cal-L Cal-L removed this pull request from the merge queue due to a manual request Oct 1, 2024
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ad1287c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46145d96-1d5e-4131-bdcb-5e06fdbba57a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Oct 1, 2024

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 1, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnyhoward vinnyhoward added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 95f9a91 Oct 1, 2024
51 of 52 checks passed
@vinnyhoward vinnyhoward deleted the fix-11481-dark-theme-alert branch October 1, 2024 20:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile team-wallet-ux
Projects
None yet
2 participants