Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry pick #11524 #11571

Merged
merged 1 commit into from
Oct 2, 2024
Merged

chore: cherry pick #11524 #11571

merged 1 commit into from
Oct 2, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Oct 2, 2024

This PR cherry-picks #11524

@salimtb salimtb requested review from a team as code owners October 2, 2024 12:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb changed the base branch from main to release/7.32.0 October 2, 2024 12:33
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 2, 2024
@salimtb salimtb changed the title Chore/cherry pick 11524 chore: cherry pick #11524 Oct 2, 2024
@salimtb salimtb added rc-cherry-picked team-assets and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Oct 2, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 2, 2024
@Andepande Andepande added the QA Passed A successful QA run through has been done label Oct 2, 2024
Andepande
Andepande approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andepande Andepande removed the QA Passed A successful QA run through has been done label Oct 2, 2024
@frankvonhoven frankvonhoven added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0895272
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8f916a6c-8ca7-4aeb-87b6-18135ff59c79

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Cal-L Cal-L merged commit e304797 into release/7.32.0 Oct 2, 2024
23 of 24 checks passed
@Cal-L Cal-L deleted the chore/cherry-pick-11524 branch October 2, 2024 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Andepande Andepande Andepande approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template rc-cherry-picked Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@salimtb @Andepande @Cal-L @metamaskbot @frankvonhoven