Sidecar debugging - Milestone 0.9 #1400

justinwilaby · 2019-03-28T00:59:03Z

"Sidecar" Debugger progress

justinwilaby · 2019-03-28T22:27:36Z

a-b-r-o-w-n

I'll need to give this a functional whirl, but I did have some comments.

packages/emulator/core/src/conversations/middleware/getConversations.ts

packages/extensions/botState/src/index.ts

packages/app/client/src/data/sagas/chatSagas.ts

packages/app/main/src/botFrameworkService.ts

packages/extensions/botState/bf-extension.json

packages/app/client/src/data/action/debugModeAction.ts

packages/app/client/src/ui/editor/emulator/parts/log/logEntry.tsx

packages/emulator/core/src/conversations/middleware/getConversations.ts

packages/app/client/src/data/sagas/chatSagas.ts

packages/extensions/botState/bf-extension.json

packages/extensions/botState/src/BotStateVisualizer.ts

a-b-r-o-w-n

I'm a little concerned that the diffing is tightly coupled to the presentation logic. It is pretty brittle at the moment. See my comment about moving the presentational logic into the extension itself.

packages/app/client/src/data/sagas/chatSagas.ts

packages/emulator/core/src/facility/conversationSet.ts

packages/extensions/botState/bf-extension.json

a-b-r-o-w-n

Can you share a screenshot of the json view with diff mode enabled?

packages/app/client/src/data/sagas/chatSagas.ts

packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.tsx

packages/extensions/botState/bf-extension.json

packages/extensions/botState/src/BotStateVisualizer.ts

coveralls · 2019-04-15T21:15:07Z

Pull Request Test Coverage Report for Build 2447

518 of 665 (77.89%) changed or added relevant lines in 71 files are covered.
21 unchanged lines in 12 files lost coverage.
Overall coverage increased (+1.3%) to 56.787%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/app/client/src/data/sagas/botSagas.ts	6	7	85.71%
packages/app/client/src/index.tsx	0	1	0.0%
packages/app/client/src/ui/shell/mdi/tabBar/tabBar.tsx	0	1	0.0%
packages/app/client/src/ui/shell/mdi/tabBar/tabBarContainer.ts	1	2	50.0%
packages/app/client/src/ui/shell/navBar/navBar.tsx	2	3	66.67%
packages/app/main/src/botHelpers.ts	5	6	83.33%
packages/app/shared/src/enums/index.ts	0	1	0.0%
packages/emulator/core/src/facility/conversationSet.ts	5	6	83.33%
packages/emulator/core/src/utils/activityVisitor.ts	1	2	50.0%
packages/app/client/src/extensions.ts	2	4	50.0%

Files with Coverage Reduction	New Missed Lines	%
packages/app/main/src/main.ts	1	0.0%
packages/app/main/src/commands/oauthCommands.ts	1	0.0%
packages/app/main/src/commands/emulatorCommands.ts	1	81.37%
packages/app/client/src/ui/shell/navBar/navBar.tsx	1	79.17%
packages/app/client/src/ui/editor/emulator/emulator.tsx	1	83.1%
packages/emulator/core/src/facility/conversation.ts	1	64.29%
packages/sdk/shared/src/utils/json2HTML.ts	1	0.0%
packages/emulator/cli/src/npmLogger.ts	1	0.0%
packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.tsx	2	85.96%
packages/emulator/core/src/directLine/middleware/startConversation.ts	2	61.9%

Totals
Change from base Build 2399:	1.3%
Covered Lines:	5241
Relevant Lines:	8676

💛 - Coveralls

…vities so webchat displays them\n3. Added a dendrogram json viewer

Co-Authored-By: justinwilaby <[email protected]>

Discussed waiting to move code until after release

justinwilaby · 2019-04-17T16:11:57Z

packages/app/client/src/commands/emulatorCommands.ts

+          endpointUrl: endpoint.endpoint,
+          userId: currentUserId,
+          conversationId,
+          // directLine: createDirectLine({


placeholder to refactor createDirectLine out of emulator.tsx and into this command. Code is commented out but works in preliminary tests.

stale

cwhitten

pending internal QA issues

…e. (#1434)

… a livechat via url. (#1436)

…JSON inspector (#1437)

* Allows injection of Conversation "mode" to support conversations started via connecting by url. * Clean up the types * Fix a test

* Changes to support saving a transcript for a conversation opened via url * add tests for getTranscriptsPath * Lint issue * Add some additional typings * Lint fixes

…BotFramework-Emulator into jwilaby/auto-connect-emulator

a-b-r-o-w-n requested changes Apr 3, 2019

View reviewed changes

cwhitten reviewed Apr 4, 2019

View reviewed changes

tonyanziano reviewed Apr 4, 2019

View reviewed changes

packages/app/client/src/data/action/debugModeAction.ts Outdated Show resolved Hide resolved

tonyanziano reviewed Apr 4, 2019

View reviewed changes

packages/app/client/src/ui/editor/emulator/parts/log/logEntry.tsx Show resolved Hide resolved

justinwilaby force-pushed the jwilaby/auto-connect-emulator branch from 5a9590d to f02db84 Compare April 5, 2019 15:42

cwhitten reviewed Apr 5, 2019

View reviewed changes

a-b-r-o-w-n previously requested changes Apr 8, 2019

View reviewed changes

packages/app/client/src/data/sagas/chatSagas.ts Show resolved Hide resolved

packages/emulator/core/src/facility/conversationSet.ts Outdated Show resolved Hide resolved

packages/extensions/botState/bf-extension.json Show resolved Hide resolved

a-b-r-o-w-n reviewed Apr 9, 2019

View reviewed changes

justinwilaby force-pushed the jwilaby/auto-connect-emulator branch 2 times, most recently from 89754c0 to 5a889d0 Compare April 12, 2019 20:27

justinwilaby marked this pull request as ready for review April 15, 2019 20:51

justinwilaby requested review from compulim and corinagum as code owners April 15, 2019 20:51

justinwilaby force-pushed the jwilaby/auto-connect-emulator branch from 6fe0c29 to bed40fc Compare April 15, 2019 21:06

justinwilaby requested a review from a-b-r-o-w-n April 15, 2019 21:33

justinwilaby added 13 commits April 15, 2019 16:32

Middleware and Emulator config for auto-connecting bot

c63e1b5

Changed Connector API to use X headers for bot related info

da5b17c

1. Completed 'sidecard' debug mode\n2. Added renderers for trace acti…

aba7597

…vities so webchat displays them\n3. Added a dendrogram json viewer

Added the new 'Bot State Visualizer' extension and wired it up

eaea35b

Completed diffing for bot state objects

d405426

Updated unit tests

1c0b5ca

Added unit tests - lint fixes

e41ffea

Rebase adjustments

5ded694

Integrated 'deep-diff' library

0d70baa

Added switching between Graph and Json views

fbafc34

Corrected errant inport

e35629f

Moved the valueType for the bot state to a const

68a7889

Simplified the chat panel. Fixed #1387

f414f4e

justinwilaby and others added 7 commits April 15, 2019 16:36

Lint fixes

2ab1ffe

Build fix

7d3e56e

Applied color treatment to json viewer for bot state diffing

87dd891

Update packages/emulator/core/src/facility/conversationSet.ts

6fdd2cf

Co-Authored-By: justinwilaby <[email protected]>

fixed #1285. Fixed #825. Added collapsed service pane when in debug mode

e83da02

Unit test remediation

40b59c0

Unit test fixes

a62e51a

justinwilaby force-pushed the jwilaby/auto-connect-emulator branch from 94302a0 to a62e51a Compare April 15, 2019 23:52

Unit test corection

829b145

This was referenced Apr 16, 2019

Revert "Allow the Emulator user to specify a User ID (#1422)" #1429

Merged

Allow the Emulator user to specify a User ID #1422

Merged

cwhitten changed the title ~~Jwilaby/auto connect emulator~~ Sidecar debugging - Milestone 0.9 Apr 16, 2019

justinwilaby added 2 commits April 17, 2019 07:47

Updated code to fix breaking changes when moving to electron 4

db222e9

Attempt to fix unit tests run on the build server

020e096

justinwilaby commented Apr 17, 2019

View reviewed changes

cwhitten previously approved these changes Apr 18, 2019

View reviewed changes

cwhitten requested changes Apr 18, 2019

View reviewed changes

tonyanziano and others added 7 commits April 19, 2019 14:03

Fixed issue where conversation restart was using a new port every tim…

d5f1dac

…e. (#1434)

Fixed issue where conversation update was not being sent when opening…

3e5bbb5

… a livechat via url. (#1436)

Remove showInInspector from the JSON object before sending it to the …

3daedb7

…JSON inspector (#1437)

Drill livechat mode (#1438)

a3b3a34

* Allows injection of Conversation "mode" to support conversations started via connecting by url. * Clean up the types * Fix a test

Save transcript fix (#1440)

ebd7330

* Changes to support saving a transcript for a conversation opened via url * add tests for getTranscriptsPath * Lint issue * Add some additional typings * Lint fixes

Disabled the restart conversation button when in sidecard debug mode

e33f0a7

Merge branch 'jwilaby/auto-connect-emulator' of github.com:Microsoft/…

468b94c

…BotFramework-Emulator into jwilaby/auto-connect-emulator

cwhitten approved these changes Apr 22, 2019

View reviewed changes

cwhitten merged commit ce2b783 into master Apr 22, 2019

cwhitten deleted the jwilaby/auto-connect-emulator branch April 22, 2019 21:50

cwhitten mentioned this pull request Apr 22, 2019

Implement Diffing Between Bot State Objects #1395

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sidecar debugging - Milestone 0.9 #1400

Sidecar debugging - Milestone 0.9 #1400

justinwilaby commented Mar 28, 2019

justinwilaby commented Mar 28, 2019

a-b-r-o-w-n left a comment

a-b-r-o-w-n left a comment

a-b-r-o-w-n left a comment

coveralls commented Apr 15, 2019 •

edited

Loading

justinwilaby Apr 17, 2019 •

edited

Loading

cwhitten left a comment

Sidecar debugging - Milestone 0.9 #1400

Sidecar debugging - Milestone 0.9 #1400

Conversation

justinwilaby commented Mar 28, 2019

justinwilaby commented Mar 28, 2019

a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

coveralls commented Apr 15, 2019 • edited Loading

Pull Request Test Coverage Report for Build 2447

💛 - Coveralls

justinwilaby Apr 17, 2019 • edited Loading

Choose a reason for hiding this comment

cwhitten left a comment

Choose a reason for hiding this comment

coveralls commented Apr 15, 2019 •

edited

Loading

justinwilaby Apr 17, 2019 •

edited

Loading