Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11: Use global.isNaN instead of Number.isNaN #1628

Merged
merged 2 commits into from
Jan 23, 2019
Merged

IE11: Use global.isNaN instead of Number.isNaN #1628

merged 2 commits into from
Jan 23, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jan 23, 2019 •
edited
Loading

Fix #1626.

Number.isNaN is not available in IE11. And in our usage, it can be replaced with global.isNaN for shorter code.

Also replaced date.valueOf() to date.getTime() for consistency.

Changelog

Fixed

@compulim compulim changed the title Use global.isNaN instead of Number.isNaN IE11: Use global.isNaN instead of Number.isNaN Jan 23, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 821

  • 3 of 21 (14.29%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 47.194%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/Localization/fr-FR.js 0 3 0.0%
packages/component/src/Localization/ja-JP.js 0 3 0.0%
packages/component/src/Localization/ru-RU.js 0 3 0.0%
packages/component/src/Localization/zh-HANS.js 0 3 0.0%
packages/component/src/Localization/zh-HANT.js 0 3 0.0%
packages/component/src/Localization/zh-YUE.js 0 3 0.0%
Totals Coverage Status
Change from base Build 811: -0.1%
Covered Lines: 786
Relevant Lines: 1503
💛 - Coveralls

justinwilaby
justinwilaby approved these changes Jan 23, 2019
View reviewed changes
Copy link

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compulim compulim merged commit 3a1926e into microsoft:master Jan 23, 2019
@compulim compulim deleted the fix-1626 branch January 23, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compulim @coveralls @justinwilaby