Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use undefined for createWebSpeechPonyfill #2009

Merged
merged 2 commits into from
May 21, 2019
Merged

Use undefined for createWebSpeechPonyfill #2009

merged 2 commits into from
May 21, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented May 20, 2019 •
edited
Loading

Fixes #2008.

Changelog Entry

Description

We are sending null to webSpeechPonyfillFactory. We should send undefined, or consider modifying our production code to accept falsy values.

Specific Changes

  • Fix webSpeechPonyfillFactory should not sending null, but undefined
  • Testing Added

@cwhitten cwhitten merged commit 3e59ffa into microsoft:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playground broken due to recent eslint fixes
2 participants
@compulim @cwhitten