Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better bracket highlight visibility #12402

Closed
waderyan opened this issue Sep 21, 2016 · 13 comments
Closed

Better bracket highlight visibility #12402

waderyan opened this issue Sep 21, 2016 · 13 comments
Assignees
Labels
ux User experience issues
Milestone

Comments

@waderyan
Copy link

From UserVoice (600 votes)

The bracket highlight is too dim to easily see with most themes. In Notepad++ the brackets change color and become bold, i think that is much easier to see. Highlighting the "current bracket set" would also be really nice.

I understand the themes can be changed in a convoluted way. For such an important feature i think the feature should be default or easily accessible.

@seanmcbreen
Copy link

We do offer bracket highlighting:
image

We also have indent guides which should help a lot here.

There are some good extensions e.g. Rainbow Brackets.
https://marketplace.visualstudio.com/items?itemName=2gua.rainbow-brackets

@waderyan
Copy link
Author

@seanmcbreen the request is to improve the visibility of bracket highlighting. OP's opinion was its too dim.

@chrmarti chrmarti added the ux User experience issues label Sep 22, 2016
@jitendravyas
Copy link

jitendravyas commented Nov 2, 2016

I'm looking for this feature. Do we have that ? https://github.com/facelessuser/BracketHighlighter

image

But VSCODE highlights every similar instance

image

And this plugin doesn't help in this case https://marketplace.visualstudio.com/items?itemName=2gua.rainbow-brackets

@bgashler1
Copy link
Contributor

bgashler1 commented Nov 2, 2016

@jitendravyas That's odd, both my light theme and dark theme are not showing the same problem as your second screenshot.screen shot 2016-11-02 at 1 31 23 pm
Our bracket matching works when your caret is on a tag. However, if you highlight-select the text of the tag, then it can be confusing because in addition to bracket matching, it will highlight all text that matches the selection (and there isn't enough contrast today to really always tell the difference). However, we will be improving color contrast to improve that scenario.

@AlexWaha
Copy link

AlexWaha commented Nov 4, 2016

How to change tag highlight background and foreground color?

@vvatikiotis
Copy link

HTML tag matching works in my theme, highlighting matching tags, when there are no JSX javascript expressions within the tags. However, tag highlighting works erratically when there are JSX javascript expressions within 2 enclosing HTML tags.

Works as intended:
image

Doesn't work:
image

@bgashler1
Copy link
Contributor

@vvatikiotis thanks for reporting that. Since it's a different issue than being discussed here, I created a new issue for you.

@billyhoomm
Copy link

may i asked this problem has resolved? i haven't find the extension like this :https://github.com/facelessuser/BracketHighlighter

@rwatts3
Copy link

rwatts3 commented Feb 25, 2017

@jitendravyas
What theme is this ?

@mjbvz mjbvz assigned stevencl and unassigned bgashler1 Apr 11, 2017
@bpasero
Copy link
Member

bpasero commented May 25, 2017

Can be done via our theming work now:

image

@bpasero bpasero closed this as completed May 25, 2017
@bpasero bpasero added this to the May 2017 milestone May 25, 2017
@kurtextrem
Copy link

I am sorry, but configuring the background or the border does not help in that case. We'd need something like "editorBracketMatch.border": "bottom #ff00ff".
See e.g. #23606 and #19534 (which was said to be tracked here).

@martinandersen3d
Copy link

And fontColor please

@loretogutierrezjr
Copy link

Hi,
It's the same problem with me.. I'm looking for some tweaks for match brackets in VS Code and I came across searching this one..

Subtle Brackets

It's working to me with the latest VS Code 1.16.1!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ux User experience issues
Projects
None yet
Development

No branches or pull requests