Update README.md #31
Update README.md #31
Conversation
Added instructions to setup Minds mobile for MacOS.
The lack of a header decreases user experience and makes it hard to see other UI elements such as time, battery, back button, etc.
To improve UX. Removed the back button arrow in the background picture because it was redundant.
Shows bottom tab on subpages. Set it to false because it improves UX.
|
Thanks for the PR! It would be great to split this up into multiple requests with a description as to each change. The headers on channels and groups have been intentionally removed. To make the back button more prominent, it might make sense to but a background on it. (There are z-index issue where it hides on iOS though.. so we need to find a way around that). We're going to have issues having the tab bar on secondary pages with routing and performance. Not totally sure if this is necessary if we have a visible back button. The Android UX in particular states that they should not have tab bar follow through. Hopefully we can merge in some of your changes soon. If you could check out the following link and get back to us, that would be great (https://docs.google.com/document/d/1bFZ1nQhOkvNKxD2ApHKigsFScy3GGQhMYY_batZl8rw/edit). |
|
|
||
| ### Local Setup, Compiling, Building instructions for iOS app | ||
| 1- Download mobile-master under /minds, open a fresh terminal and enter the following commands: | ||
| 2- sudo npm install -g cordova |
There was a problem hiding this comment.
This can be omitted as you are including in step 3 also.
| @@ -82,3 +82,25 @@ Run `ionic build` | |||
| Minds supports multiple environments. See `config/config-example.js` for an example. | |||
|
|
|||
| To run a production build run `export config_target=prod; cordova build` | |||
|
|
|||
| ### Local Setup, Compiling, Building instructions for iOS app | |||
| 1- Download mobile-master under /minds, open a fresh terminal and enter the following commands: | |||
There was a problem hiding this comment.
This repo doesn't need to be under the Minds repo unlike engine and front.
| 1- Download mobile-master under /minds, open a fresh terminal and enter the following commands: | ||
| 2- sudo npm install -g cordova | ||
| 3- sudo npm install -g cordova ionic | ||
| 4- sudo npm -g install grunt-cli |
| 7- npm install ios-sim | ||
| 8- cordova platform add ios | ||
| 9- cordova build ios //build should succeed at this point | ||
| 10- sudo npm install -g gulp |
There was a problem hiding this comment.
I think you can ditch the whole gulp step
| 5- cd [PathToYourApp]/mobile-master | ||
| 6- npm install | ||
| 7- npm install ios-sim | ||
| 8- cordova platform add ios |
There was a problem hiding this comment.
make sure you prefix ionic before any cordova command
| @@ -82,3 +82,25 @@ Run `ionic build` | |||
| Minds supports multiple environments. See `config/config-example.js` for an example. | |||
|
|
|||
| To run a production build run `export config_target=prod; cordova build` | |||
|
|
|||
| ### Local Setup, Compiling, Building instructions for iOS app | |||
There was a problem hiding this comment.
Removing the numbers below should help the markdown render correctly.
| gulp.task('default', function () { console.log('Hello Gulp!') }); | ||
| 14- ionic cordova run ios --target="[your phone choice]" | ||
|
|
||
| psd: Once it starts running, you should also enable "toggle software keyboard" with command+K to enable the iphone keyboard. |
There was a problem hiding this comment.
For the purposes of this repository, I think this is out of the scope. Perhaps add this to the Wiki or something?
|
@markharding Hi Mark, thanks for the review As for the tab changes, I've only tried them for IOS since I don't have an Android phone. I added them for convenience; the lack of the bottom tab forces the user to hit the back button 3-4 times to get to the newsfeed. On top of that, the back button is invisible and often unresponsive. The steps that I set to get the mobile app running might not be ideal, but there were no instructions and it kept crashing on my system when trying to build the project. I developed that set of steps as a solution to get the app running and repeated over five times to make sure it worked. The code from gulpfile.js might be out of the scope but my objective was to make the process as simple as possible for anybody wishing to contribute to the app. |
Added instructions to setup Minds mobile for MacOS and run app on IOS emulator.
I think any developer would find it useful.