Skip to content
This repository has been archived by the owner on Mar 28, 2018. It is now read-only.

Update README.md #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update README.md #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2f0dc3
Update README.md
Sep 27, 2017
f4ca121
Added header to channel component
Oct 2, 2017
85b0d91
Added header to profile component
Oct 2, 2017
a1b725a
Enabled footer tabs to all subviews
Oct 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,25 @@ Run `ionic build`
Minds supports multiple environments. See `config/config-example.js` for an example.

To run a production build run `export config_target=prod; cordova build`

### Local Setup, Compiling, Building instructions for iOS app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the numbers below should help the markdown render correctly.

1- Download mobile-master under /minds, open a fresh terminal and enter the following commands:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo doesn't need to be under the Minds repo unlike engine and front.

2- sudo npm install -g cordova
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be omitted as you are including in step 3 also.

3- sudo npm install -g cordova ionic
4- sudo npm -g install grunt-cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grunt is not required

5- cd [PathToYourApp]/mobile-master
6- npm install
7- npm install ios-sim
8- cordova platform add ios
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you prefix ionic before any cordova command

9- cordova build ios //build should succeed at this point
10- sudo npm install -g gulp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can ditch the whole gulp step

11- sudo chown -v -R -L [yourUserName] [PathToYourApp]/mobile-master
12- touch gulpfile.js
13- On Finder, open [PathToYourApp]/mobile-master/gulpfile.js on a text editor and paste this block of code:
var gulp = require('gulp');
gulp.task('default', function () { console.log('Hello Gulp!') });
14- ionic cordova run ios --target="[your phone choice]"

psd: Once it starts running, you should also enable "toggle software keyboard" with command+K to enable the iphone keyboard.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the purposes of this repository, I think this is out of the scope. Perhaps add this to the Wiki or something?



2 changes: 1 addition & 1 deletion src/app/app.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { routes } from "./app.routes";
],
imports: [
IonicModule.forRoot(MindsApp, {
tabsHideOnSubPages: true,
tabsHideOnSubPages: false, //Shows bottom tab on subpages. Set it to false because it improves UX.
tabsPlacement: 'bottom',
platforms: {
android: {
Expand Down
6 changes: 4 additions & 2 deletions src/app/modules/channel/channel.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
<ion-header>
<ion-navbar>

</ion-navbar>
</ion-header>

<ion-content scroll="false" #scrollArea>

<ion-refresher (ionRefresh)="refresh($event)">
<ion-refresher-content></ion-refresher-content>
</ion-refresher>

<ion-icon name="md-arrow-round-back" class="m-ionic-back-button" navPop></ion-icon>

<ion-icon name="md-arrow-dropdown" class="m-ionic-channel--actions-button" (click)="openActions()"></ion-icon>

<div class="m-ionic-channel--header" *ngIf="channel.guid">
Expand Down
6 changes: 4 additions & 2 deletions src/app/modules/groups/profile.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
<ion-header>
<ion-navbar>

</ion-navbar>
</ion-header>

<ion-content #scrollArea>

<ion-refresher (ionRefresh)="refresh($event)">
<ion-refresher-content></ion-refresher-content>
</ion-refresher>

<ion-icon name="md-arrow-round-back" class="m-ionic-back-button" navPop></ion-icon>

<div class="m-ionic-group--header" *ngIf="group && group.guid">

<div class="m-ionic-group--header-banner">
Expand Down