Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new fields to a fieldmap is faster and involves less code duplication. #334

Merged
merged 27 commits into from
Jan 6, 2020
Merged

Adding new fields to a fieldmap is faster and involves less code duplication. #334

merged 27 commits into from
Jan 6, 2020

Commits on Jan 4, 2020

  1. update node stuff

    @jonathanstegall
    jonathanstegall committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    118bf65 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2020

  1. put the fieldset template into the html so it can be cloned. hide it … 

    …if there are already rows present.
    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    b1a5078 View commit details
    Browse the repository at this point in the history

  2. we can't fail linting over underscores with the way other people's co… 

    …de works
    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    e39d02d View commit details
    Browse the repository at this point in the history

  3. always hide the template row

    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    8dbe298 View commit details
    Browse the repository at this point in the history

  4. fix the template row so it works before there is a fieldmap also

    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    78095e0 View commit details
    Browse the repository at this point in the history

  5. deprecate wp object description method; rename to fields for what it … 

    …actually does, and add 'fields' to the ajax response accordingly
    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    7719342 View commit details
    Browse the repository at this point in the history

  6. deprecate the combined method as well

    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    313202b View commit details
    Browse the repository at this point in the history

  7. allow salesforce_object_fields to be ajax method. filter which attrib… 

    …utes get returned, in that case.
    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    edf92ed View commit details
    Browse the repository at this point in the history

  8. make adding a new fieldset to the fieldmap driven by a template from … 

    …the server, not from the javascript. also, allow it to regenerate whenever the wp or sf object changes
    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    29a7fcf View commit details
    Browse the repository at this point in the history

  9. allow the script to work on a page refresh. also make sure both objec… 

    …t types have a value.
    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    06d658c View commit details
    Browse the repository at this point in the history

  10. never delete that template row though

    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    8017ff2 View commit details
    Browse the repository at this point in the history

  11. don't replace on existing fieldmaps

    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    8ac45a6 View commit details
    Browse the repository at this point in the history

  12. convert post to ajax so we can control the spinners individually

    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    af39cb5 View commit details
    Browse the repository at this point in the history

  13. fix spinner markup. also cleanup comments.

    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    000fc54 View commit details
    Browse the repository at this point in the history

  14. update the comments, combine the script, etc

    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    6ec64ae View commit details
    Browse the repository at this point in the history

  15. update the changelog

    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    a437542 View commit details
    Browse the repository at this point in the history

  16. fix incorrect colspan

    @jonathanstegall
    jonathanstegall committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    f50a654 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. use iife to combine javascript and prepend it

    @jonathanstegall
    jonathanstegall committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    3e5e4a5 View commit details
    Browse the repository at this point in the history

  2. separate javascript into multiple files that get concatenated

    @jonathanstegall
    jonathanstegall committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    1597ebf View commit details
    Browse the repository at this point in the history

  3. better organize scripts

    @jonathanstegall
    jonathanstegall committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    32bb3fd View commit details
    Browse the repository at this point in the history

  4. eslint

    @jonathanstegall
    jonathanstegall committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    5cf8785 View commit details
    Browse the repository at this point in the history

  5. eslint

    @jonathanstegall
    jonathanstegall committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    e99b143 View commit details
    Browse the repository at this point in the history

  6. move deprecated actions into another method

    @jonathanstegall
    jonathanstegall committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    572f927 View commit details
    Browse the repository at this point in the history

  7. more eslint

    @jonathanstegall
    jonathanstegall committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    f6be108 View commit details
    Browse the repository at this point in the history

  8. more eslint

    @jonathanstegall
    jonathanstegall committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    3f4a78b View commit details
    Browse the repository at this point in the history

  9. more eslint

    @jonathanstegall
    jonathanstegall committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    5b8200b View commit details
    Browse the repository at this point in the history

  10. spaces and tabs

    @jonathanstegall
    jonathanstegall committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    8ccd2f8 View commit details
    Browse the repository at this point in the history